Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce variable hosts_discovery_minutes #290

Conversation

newkit
Copy link

@newkit newkit commented Nov 21, 2023

in order to make host discovery timeout configurable

@newkit newkit requested a review from a team as a code owner November 21, 2023 18:33
Copy link
Collaborator

@nocturnalastro nocturnalastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into the defaults file that the default only in one place

@newkit
Copy link
Author

newkit commented Nov 23, 2023

@nocturnalastro Do you mean like this?

Copy link
Collaborator

@nocturnalastro nocturnalastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, like that there is only one place to change the defaults which makes life a lot easier and the tasks just look cleaner :)

@nocturnalastro
Copy link
Collaborator

@newkit Could squash your commits for me then I'll get it merged :)

@newkit newkit force-pushed the feature_timeout_host_discover_variable branch from 60753e4 to b2785ae Compare November 27, 2023 11:13
@newkit
Copy link
Author

newkit commented Nov 27, 2023

@nocturnalastro All commits are squashed into one now.

@nocturnalastro nocturnalastro force-pushed the feature_timeout_host_discover_variable branch from b2785ae to 02ede8c Compare November 28, 2023 10:05
@nocturnalastro nocturnalastro merged commit ce6a499 into redhat-partner-solutions:main Nov 28, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants