Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sushy emulator ignore boot device optional #272

Closed
wants to merge 12 commits into from

Conversation

nsilla
Copy link
Contributor

@nsilla nsilla commented Sep 19, 2023

The "ignore boot device" parameter instructs the sushy emulator to
override the default boot device, which is usually the discovery iso.

By making this parameter optional, we give the user control over whether
the default boot device should be used or not.

@nsilla nsilla requested a review from a team as a code owner September 19, 2023 12:35
@dcibot
Copy link

dcibot commented Sep 20, 2023

Starting dci-check-change job.

1 similar comment
@dcibot
Copy link

dcibot commented Sep 20, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Sep 20, 2023

@dcibot
Copy link

dcibot commented Sep 20, 2023

  • dci-check-change preparation : FAILURE tested on libvirt:virt

@dcibot
Copy link

dcibot commented Sep 20, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Sep 20, 2023

@dcibot
Copy link

dcibot commented Sep 28, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Sep 28, 2023

  • dci-check-change preparation : FAILURE tested on libvirt:virt

@dcibot
Copy link

dcibot commented Oct 4, 2023

Starting dci-check-change job.

1 similar comment
@dcibot
Copy link

dcibot commented Oct 4, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 4, 2023

  • dci-check-change preparation : KILLED tested on libvirt:virt

@dcibot
Copy link

dcibot commented Oct 4, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 4, 2023

  • dci-check-change preparation : FAILURE tested on libvirt:virt

@dcibot
Copy link

dcibot commented Oct 4, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 4, 2023

  • dci-check-change preparation : FAILURE tested on libvirt:virt

@dcibot
Copy link

dcibot commented Oct 5, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 5, 2023

  • dci-check-change preparation : FAILURE tested on libvirt:virt

@dcibot
Copy link

dcibot commented Oct 5, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 5, 2023

@dcibot
Copy link

dcibot commented Oct 6, 2023

Starting dci-check-change job.

1 similar comment
@dcibot
Copy link

dcibot commented Oct 6, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 6, 2023

  • dci-check-change preparation : KILLED tested on libvirt:virt

@dcibot
Copy link

dcibot commented Oct 6, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 6, 2023

@dcibot
Copy link

dcibot commented Oct 6, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 6, 2023

@dcibot
Copy link

dcibot commented Oct 6, 2023

@dcibot
Copy link

dcibot commented Oct 9, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 9, 2023

  • dci-check-change preparation : FAILURE tested on libvirt:virt

@dcibot
Copy link

dcibot commented Dec 5, 2023

ERROR unable to rebase PR 272 from redhat-partner-solutions/crucible branch main

@nsilla nsilla force-pushed the ignore_boot_device branch from 21e89f4 to ad2d3df Compare December 5, 2023 10:52
@dcibot
Copy link

dcibot commented Dec 5, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Dec 5, 2023

@dcibot
Copy link

dcibot commented Dec 5, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Dec 5, 2023

nsilla added a commit to nsilla/ansible-collection-redhatci-ocp that referenced this pull request Dec 19, 2023
Currently ocp-on-libvirt installs the conserver service along with the
VMs to allow for IPMI remote management of the hosts, which in turn
allows for PXE image boot up.

In order to support ZTP deployments, virtual media image boot up is
needed, and to manage it remotely, the target server BMCs must suport
the redfish protocol.

Sushy tools provides support for the redfish protocol for libvirt VMs.

This change installs sushy tools, as implemented in the
assisted-installer ansible project,  when running the ocp-on-libvirt
role.

Depends-On: dci-labs/bos2-ci-config#72
Depends-On: openshift-kni/baremetal-deploy#975
Depends-On: redhat-partner-solutions/crucible#272
Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
@dcibot
Copy link

dcibot commented Dec 19, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Dec 19, 2023

@dcibot
Copy link

dcibot commented Dec 19, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Dec 19, 2023

@dcibot
Copy link

dcibot commented Dec 19, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Dec 19, 2023

nsilla added a commit to nsilla/ansible-collection-redhatci-ocp that referenced this pull request Jan 9, 2024
Currently ocp-on-libvirt installs the conserver service along with the
VMs to allow for IPMI remote management of the hosts, which in turn
allows for PXE image boot up.

In order to support ZTP deployments, virtual media image boot up is
needed, and to manage it remotely, the target server BMCs must suport
the redfish protocol.

Sushy tools provides support for the redfish protocol for libvirt VMs.

This change installs sushy tools, as implemented in the
assisted-installer ansible project,  when running the ocp-on-libvirt
role.

Depends-On: dci-labs/bos2-ci-config#72
Depends-On: openshift-kni/baremetal-deploy#975
Depends-On: redhat-partner-solutions/crucible#272
Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla added a commit to nsilla/ansible-collection-redhatci-ocp that referenced this pull request Feb 5, 2024
Currently ocp-on-libvirt installs the conserver service along with the
VMs to allow for IPMI remote management of the hosts, which in turn
allows for PXE image boot up.

In order to support ZTP deployments, virtual media image boot up is
needed, and to manage it remotely, the target server BMCs must suport
the redfish protocol.

Sushy tools provides support for the redfish protocol for libvirt VMs.

This change installs sushy tools, as implemented in the
assisted-installer ansible project,  when running the ocp-on-libvirt
role.

Depends-On: dci-labs/bos2-ci-config#72
Depends-On: openshift-kni/baremetal-deploy#975
Depends-On: redhat-partner-solutions/crucible#272
Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla added a commit to nsilla/ansible-collection-redhatci-ocp that referenced this pull request Feb 9, 2024
Currently ocp-on-libvirt installs the conserver service along with the
VMs to allow for IPMI remote management of the hosts, which in turn
allows for PXE image boot up.

In order to support ZTP deployments, virtual media image boot up is
needed, and to manage it remotely, the target server BMCs must suport
the redfish protocol.

Sushy tools provides support for the redfish protocol for libvirt VMs.

This change installs sushy tools, as implemented in the
assisted-installer ansible project,  when running the ocp-on-libvirt
role.

Depends-On: dci-labs/bos2-ci-config#72
Depends-On: openshift-kni/baremetal-deploy#975
Depends-On: redhat-partner-solutions/crucible#272
Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
@arjuhe
Copy link
Collaborator

arjuhe commented Mar 30, 2024

Closing pull request as project is being archived.

@arjuhe arjuhe closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants