Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift "No 'Optional:' titles" rule #886

Merged

Conversation

apinnick
Copy link
Collaborator

@apinnick apinnick commented Sep 19, 2024

Add an OpenShiftAsciiDoc rule that flags "Optional:" in titles as an error.

Copy link

github-actions bot commented Sep 19, 2024

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-886.surge.sh 🎊

@apinnick apinnick force-pushed the ocp-no-optional-in-header branch from 4be056e to 0e09ec1 Compare September 19, 2024 11:29
@apinnick apinnick marked this pull request as ready for review September 19, 2024 11:30
@apinnick apinnick force-pushed the ocp-no-optional-in-header branch from 0e09ec1 to c136dbd Compare September 19, 2024 11:31
Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small (optional) nit. Otherwise /lgtm

.vale/styles/OpenShiftAsciiDoc/NoOptionalInHeader.yml Outdated Show resolved Hide resolved
@apinnick apinnick force-pushed the ocp-no-optional-in-header branch from c136dbd to d2f03f3 Compare September 19, 2024 12:40
@apinnick apinnick changed the title Add OpenShift "No 'Optional:' in header" rule Add OpenShift "No 'Optional:' titles" rule Sep 19, 2024
@apinnick apinnick merged commit 800a614 into redhat-documentation:main Sep 19, 2024
4 checks passed
@apinnick apinnick deleted the ocp-no-optional-in-header branch September 19, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants