Add part-of-speech rule for [noun + using] #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
|
⚡️ Deploying PR Preview... |
aireilly
force-pushed
the
add-pos-using-rule
branch
4 times, most recently
from
1a370d2 to
eeb8d25
Compare
aireilly
force-pushed
the
add-pos-using-rule
branch
from
eeb8d25 to
134a459
Compare
aireilly
force-pushed
the
add-pos-using-rule
branch
5 times, most recently
from
f7f1c0e to
0646efd
Compare
rohennes
approved these changes
Jul 23, 2024
rohennes
reviewed
Jul 23, 2024
aireilly
force-pushed
the
add-pos-using-rule
branch
14 times, most recently
from
bd72fc8 to
aa381b7
Compare
aireilly
force-pushed
the
add-pos-using-rule
branch
8 times, most recently
from
15c2d6f to
8217db4
Compare
aireilly
force-pushed
the
add-pos-using-rule
branch
from
8217db4 to
7c52c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
TermsSuggestions.ymlrule for"(?<![Bb]y) using": by using|that usesfires lots of false positives for "using". For example, "You are using the computer." should not raise a Vale error.https://studio.vale.sh/s/0d3e250c6fcaed40fb64cb8b797f7f7f
Tested against openshift-docs with:
PR also removes
.github/workflows/web-ide-link.ymland updates the validate-rules job to use the latest version of Vale, which is required for this rule.Also various clean up items for new vale version 3.7.0.