-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unset attribute rule #729
Adding unset attribute rule #729
Conversation
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-729.surge.sh 🎊 |
db2c76e
to
7f950ec
Compare
This rule does not account for specific ifeval situations.
Update the rule to respect ifeval boundaries. For example, how can we validate this? https://github.com/aireilly/openshift-docs/blob/add-symlinks-to-codeowners/modules/cco-ccoctl-configuring.adoc?plain=1 |
660954b
to
0b7fb82
Compare
b481518
to
d1b0c27
Compare
Hacked around this by just counting set and unset attributes |
d1b0c27
to
08d0222
Compare
/cc |
What does this mean? |
@jeana-redhat Given upcoming tooling changes, I don't think I will be able to spend more time getting this into a better state for AsciiDoc, this will have to do. |
well, in other repos, it seems to mark you as a reviewer. I was planning to come back around on this 😅 |
08d0222
to
13756dd
Compare
13756dd
to
9a00270
Compare
9a00270
to
620790f
Compare
620790f
to
2b927b1
Compare
Merging this since it's reasonably useful and we're moving off AsciiDoc so why not? 🤷 |
Adds a new AsciiDoc rule that highlights when an attribute is not unset in the same file.
The rule fires for an attribute that is not unset in the file.