Added rule: for instance #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-690.surge.sh 🎊 |
|
Click here to review and test in web IDE: |
aireilly
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Regex lgtm, but wouldn't it be better to include this fix in the TermsErrors.yml rule? then we would be able to include a quickfix with the Substitution rule.
'(?<= )for instance(?=,)': for example
re: "Should we also check for "for instance" with spaces before and after?"
If there is a chance of false positives, I would be inclined to not include this version.
gaurav-nelson
force-pushed
the
fix-687
branch
from
d11f1e4 to
c756bc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #687
New rule: Checks if there is a space before and a comma following "for instance".
question: ❔ Should we also check for "for instance" with spaces before and after?