Merge pull request #11 from makentenza/ldap-sync-review

Ldap sync review

jobs/README.md

@@ -64,13 +64,14 @@ The `scheduledjob-ldap-group-sync` template creates several objects in OpenShift
 
 To instantiate the template, run the following.
 
-1. Create a project in which to host your jobs. Currently the template requires that it be created in a project called `cluster-ops`. This will become more flexible in future versions of OpenShift.
+1. Create a project in which to host your jobs.
 	```
-	oc new-project cluster-ops
+	oc new-project <project>
 	```
 2. Instantiate the template
 	```
 	oc process -f jobs/scheduledjob-ldap-group-sync.yml \
+	  -p NAMESPACE="<project name from previous step>"
 	  -p LDAP_URL="ldap://idm-2.etl.rht-labs.com:389" \
 	  -p LDAP_BIND_DN="uid=ldap-user,cn=users,cn=accounts,dc=myorg,dc=example,dc=com" \
 		-p LDAP_BIND_PASSWORD="password1" \

jobs/scheduledjob-ldap-group-sync.yml

@@ -108,14 +108,18 @@ objects:
   - kind: ServiceAccount
     name: ${JOB_SERVICE_ACCOUNT}
   userNames:
-  - system:serviceaccount:cluster-ops:${JOB_SERVICE_ACCOUNT}
+  - system:serviceaccount:${NAMESPACE}:${JOB_SERVICE_ACCOUNT}
 - apiVersion: v1
   kind: ServiceAccount
   metadata:
     name: ${JOB_SERVICE_ACCOUNT}
     labels:
       template: "scheduledjob-ldap-group-sync"
 parameters:
+  - name: "NAMESPACE"
+    displayName: "Namespace"
+    description: "Name of the Namespace where to deploy the Scheduled Job"
+    required: true
   - name: "JOB_NAME"
     displayName: "Job Name"
     description: "Name of the Scheduled Job to Create."