Adding Choice model and votes #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulisuliman
requested changes
Apr 12, 2022
OmerCS8
force-pushed
the
choise-vote
branch
2 times, most recently
from
9962ecc to
f630622
Compare
yulisuliman
previously approved these changes
Apr 21, 2022
TomerNewmanPrograms
previously approved these changes
Apr 28, 2022
OmerCS8
requested review from
TomerNewmanPrograms,
yulisuliman,
natifridman,
AlonShakaroff and
abiton1
- Adding a Choice model that stores choice options of a poll and votes - Adding tests
yulisuliman
approved these changes
May 1, 2022
TomerNewmanPrograms
requested changes
May 1, 2022
| @@ -0,0 +1,514 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
I believe we moved the tests out from posts to Resume/tests/posts_tests.py
abiton1
reviewed
May 15, 2022
Comment on lines
+343
to
+345
| def test_pollFile_invalid_args(self, poll, choice_text, expected_error): | ||
| with pytest.raises(expected_error): | ||
| PollFile(poll=poll, file=choice_text) |
There was a problem hiding this comment.
Why do we try to create PollFile?
Shouldn't we try to create Choice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding migrations
fix #53
Dependant on #52