Add GitArchive information to BuildAttempt #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnc
force-pushed
the
STONEBLD1972
branch
2 times, most recently
from
2e5a483 to
8dffd3a
Compare
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
============================================
- Coverage 44.53% 44.52% -0.01%
+ Complexity 614 609 -5
============================================
Files 237 237
Lines 10332 10352 +20
Branches 1079 1081 +2
============================================
+ Hits 4601 4609 +8
- Misses 5236 5247 +11
- Partials 495 496 +1 ☔ View full report in Codecov by Sentry. |
rnc
force-pushed
the
STONEBLD1972
branch
2 times, most recently
from
f364104 to
5725810
Compare
rnc
commented
Nov 28, 2023
Comment on lines
+679
to
684
| // TODO: What is the difference between this and PipelineResultDeployedResources? | ||
| deployed := strings.Split(i.Value.StringVal, ",") | ||
| db.Status.DeployedArtifacts = deployed | ||
| } else if i.Name == artifactbuild.PipelineResultDeployedResources && len(i.Value.StringVal) > 0 { | ||
| //we need to create 'DeployedArtifact' resources for the objects that were deployed | ||
| deployed = strings.Split(i.Value.StringVal, ",") |
There was a problem hiding this comment.
These appear to be storing the same information?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #938 merged first
For: STONEBLD-1972