Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage #936

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix coverage #936

merged 1 commit into from
Nov 27, 2023

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Nov 24, 2023

This:

  • Removes running builds, some tests and some coverage on merge to main.
  • Fixes cache errors in the GoLang tests.
  • Add missing Java code coverage.
  • Add back coverage commenting.

Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23b43a1) 53.94% compared to head (a240323) 44.48%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #936      +/-   ##
============================================
- Coverage     53.94%   44.48%   -9.46%     
- Complexity        0      614     +614     
============================================
  Files            14      237     +223     
  Lines          3172    10353    +7181     
  Branches          0     1079    +1079     
============================================
+ Hits           1711     4606    +2895     
- Misses         1268     5250    +3982     
- Partials        193      497     +304     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc rnc force-pushed the BR2 branch 3 times, most recently from a41828c to 1d6c045 Compare November 24, 2023 09:58
@rnc rnc marked this pull request as ready for review November 24, 2023 10:02
@openshift-ci openshift-ci bot requested review from mmorhun and psturc November 24, 2023 10:02
@rnc rnc requested review from stuartwdouglas and removed request for psturc and mmorhun November 24, 2023 10:05
@stuartwdouglas stuartwdouglas merged commit 58d8c14 into redhat-appstudio:main Nov 27, 2023
19 of 20 checks passed
@rnc rnc deleted the BR2 branch November 28, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants