Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STONEBLD-1518: Allow disabling plugins from YAML #923

Merged
merged 17 commits into from
Dec 4, 2023

Conversation

dwalluck
Copy link
Member

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 15, 2023

@dwalluck: This pull request references STONEBLD-1518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dwalluck dwalluck force-pushed the STONEBLD-1518 branch 2 times, most recently from a3c37f8 to df32a34 Compare November 15, 2023 21:18
@@ -53,6 +53,10 @@
<groupId>io.quarkiverse.jgit</groupId>
<artifactId>quarkus-jgit</artifactId>
</dependency>
<dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this change was required. IDEA seemed to want it.

@dwalluck dwalluck marked this pull request as ready for review November 22, 2023 19:49
@stuartwdouglas
Copy link
Contributor

/retest

@rnc
Copy link
Collaborator

rnc commented Nov 29, 2023

Could we squash to get rid of Merge remote-tracking branch 'upstream/main' into [STONEBLD-1518](https://issues.redhat.com//browse/STONEBLD-1518) (or use rebase in future?) ?

@stuartwdouglas
Copy link
Contributor

/retest

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (26b3168) 44.52% compared to head (1882a24) 44.48%.

Files Patch % Lines
pkg/reconciler/dependencybuild/buildrecipeyaml.go 0.00% 11 Missing and 1 partial ⚠️
...at/hacbs/artifactcache/services/RecipeManager.java 0.00% 9 Missing ⚠️
...rtifactcache/resources/V2RecipeLookupResource.java 0.00% 4 Missing ⚠️
...cipies/disabledplugins/DisabledPluginsManager.java 62.50% 3 Missing ⚠️
...dhat/hacbs/container/analyser/build/BuildInfo.java 0.00% 3 Missing ⚠️
...hat/hacbs/container/analyser/build/Invocation.java 57.14% 2 Missing and 1 partial ⚠️
...bs/container/analyser/build/InvocationBuilder.java 57.14% 2 Missing and 1 partial ⚠️
.../build/preprocessor/maven/MavenPrepareCommand.java 66.66% 1 Missing and 2 partials ⚠️
...t/hacbs/recipies/location/RecipeLayoutManager.java 33.33% 2 Missing ⚠️
...cbs/recipies/location/RecipeRepositoryManager.java 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #923      +/-   ##
============================================
- Coverage     44.52%   44.48%   -0.04%     
- Complexity      609      611       +2     
============================================
  Files           237      239       +2     
  Lines         10352    10421      +69     
  Branches       1081     1090       +9     
============================================
+ Hits           4609     4636      +27     
- Misses         5247     5284      +37     
- Partials        496      501       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartwdouglas
Copy link
Contributor

/retest

@stuartwdouglas stuartwdouglas merged commit b68d8b6 into redhat-appstudio:main Dec 4, 2023
18 checks passed
@dwalluck dwalluck deleted the STONEBLD-1518 branch January 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants