Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate maven repo deployment code #880

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Integrate maven repo deployment code #880

merged 2 commits into from
Oct 23, 2023

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Oct 18, 2023 •
edited
Loading

Requires #872 merged first.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rnc rnc force-pushed the APH1 branch 5 times, most recently from aa54742 to 06adf04 Compare October 19, 2023 06:58
@rnc rnc changed the title STONEBLD-1514 Add CLI for class diagnostic Integrate maven repo deployment code Oct 19, 2023
rnc
rnc commented Oct 19, 2023
View reviewed changes
...equest-processor/src/main/java/com/redhat/hacbs/container/analyser/deploy/DeployCommand.java
@@ -103,154 +126,145 @@ public DeployCommand(BeanManager beanManager,

public void run() {
try {
java.nio.file.Path modified = Files.createTempFile("deployment", ".tar.gz");
try {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was left over from #477

@rnc rnc marked this pull request as ready for review October 20, 2023 08:33
@openshift-ci openshift-ci bot requested review from gabemontero and psturc October 20, 2023 08:33
@gabemontero gabemontero requested review from stuartwdouglas and removed request for gabemontero October 20, 2023 16:34
@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2023
@stuartwdouglas stuartwdouglas merged commit 0501788 into redhat-appstudio:main Oct 23, 2023
17 checks passed
@rnc rnc deleted the APH1 branch October 23, 2023 10:22
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@psturc psturc Awaiting requested review from psturc

Assignees

@stuartwdouglas stuartwdouglas

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnc @stuartwdouglas