Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain proxy integration #2153

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

tecarter94
Copy link
Contributor

@tecarter94 tecarter94 commented Oct 8, 2024

Convert domain proxy from Java to Go. Integrate domain proxy into buildah-oci-ta. Add generic internal proxy support to domain proxy. Integrate building of domain proxy into pipeline build processes. Implement domain proxy integration tests.

https://issues.redhat.com/browse/JBS-54

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tecarter94 tecarter94 changed the title Domain proxy improv Domain proxy improvements Oct 8, 2024
@tecarter94
Copy link
Contributor Author

/test all

@tecarter94 tecarter94 marked this pull request as ready for review October 8, 2024 08:02
@openshift-ci openshift-ci bot requested review from rnc and vibe13 October 8, 2024 08:02
@tecarter94 tecarter94 marked this pull request as draft October 8, 2024 08:02
@tecarter94 tecarter94 removed request for rnc and vibe13 October 8, 2024 08:02
@rnc rnc mentioned this pull request Oct 8, 2024
@tecarter94 tecarter94 assigned tecarter94 and unassigned tecarter94 Oct 9, 2024
@tecarter94 tecarter94 changed the title Domain proxy improvements Domain proxy integration Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 70.33748% with 167 lines in your changes missing coverage. Please review.

Project coverage is 44.61%. Comparing base (be23096) to head (5780abf).

Files with missing lines Patch % Lines
pkg/domainproxy/server/server.go 65.39% 80 Missing and 20 partials ⚠️
pkg/domainproxy/common/common.go 73.07% 30 Missing and 5 partials ⚠️
pkg/domainproxy/client/client.go 61.76% 21 Missing and 5 partials ⚠️
pkg/reconciler/dependencybuild/buildrecipeyaml.go 95.58% 2 Missing and 1 partial ⚠️
pkg/reconciler/dependencybuild/dependencybuild.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2153      +/-   ##
============================================
+ Coverage     43.54%   44.61%   +1.06%     
+ Complexity      802      780      -22     
============================================
  Files           280      279       -1     
  Lines         13345    13761     +416     
  Branches       1348     1339       -9     
============================================
+ Hits           5811     6139     +328     
- Misses         6934     6997      +63     
- Partials        600      625      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tecarter94 tecarter94 force-pushed the domain-proxy branch 9 times, most recently from e897253 to d0a4dd3 Compare October 28, 2024 02:42
@tecarter94 tecarter94 removed the request for review from vibe13 December 3, 2024 00:40
@tecarter94
Copy link
Contributor Author

/test all

@tecarter94
Copy link
Contributor Author

/retest

@tecarter94 tecarter94 marked this pull request as ready for review December 11, 2024 01:15
@openshift-ci openshift-ci bot requested a review from vibe13 December 11, 2024 01:15
@tecarter94 tecarter94 marked this pull request as draft December 11, 2024 01:18
@tecarter94 tecarter94 force-pushed the domain-proxy branch 4 times, most recently from db4a41d to 8a14928 Compare December 11, 2024 03:29
…ort to domain proxy. Integrate building of domain proxy into pipeline build processes. Implement domain proxy integration tests.
@tecarter94 tecarter94 marked this pull request as ready for review December 11, 2024 04:03
@tecarter94
Copy link
Contributor Author

The domain proxy specific buildah-oci-ta changes. @rnc @matejonnet

Screenshot From 2024-12-11 13-45-27
Screenshot From 2024-12-11 13-40-43
Screenshot From 2024-12-11 13-36-33

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@tecarter94: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e 52624af link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rnc
Copy link
Collaborator

rnc commented Dec 11, 2024

This all looks goodat first glance. While I realise the e2e tests are failing given STONEBLD-2711 I don't think we should be too concerned about them tbh.

@tecarter94 tecarter94 merged commit b57f71e into redhat-appstudio:main Dec 17, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants