Convert pre-build task to yaml. #2117
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2117 +/- ##
============================================
+ Coverage 39.55% 39.71% +0.15%
Complexity 812 812
============================================
Files 301 301
Lines 13994 14034 +40
Branches 1468 1468
============================================
+ Hits 5536 5573 +37
- Misses 7821 7823 +2
- Partials 637 638 +1 ☔ View full report in Codecov by Sentry. |
| name: jvm-build-git-secrets | ||
| key: .git-credentials | ||
| script: | | ||
| $(params.GIT_SCRIPT) |
There was a problem hiding this comment.
Currently not using Konflux git clone task but the original simple git clone from JBS and passing it through as a script from the operator.
There was a problem hiding this comment.
The more we use Konflux's tasks the better I think, but not a problem for now to use our own. Can be a subsequent PR.
| cpu: 10m | ||
| memory: 512Mi | ||
| script: | | ||
| $(params.BUILD_SCRIPT) |
There was a problem hiding this comment.
To embed the Containerfile / build-script into the repository currently passing them through from the operator (which is generating them). Eventually I think the preprocessor should generate them (for the following steps (create-pre-build-source and create-pre-build-image) to use).
There was a problem hiding this comment.
Yes I believe it would be cleaner that the preprocessor generates the build script and propagates it as a result to following steps. Can be a subsequent PR.
| Name: "url", | ||
| Value: tektonpipeline.ParamValue{ | ||
| Type: tektonpipeline.ParamTypeString, | ||
| StringVal: "https://raw.githubusercontent.com/rnc/jvm-build-service/KJB11/deploy/tasks/pre-build.yaml", |
There was a problem hiding this comment.
As per prior PRs will need a follow-up PR to correct the branch/repo.
|
@rnc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| func (ta *testArgs) Logf(msg string) { | ||
| ta.t.Logf("time: %s: %s", time.Now().String(), msg) | ||
| } |
There was a problem hiding this comment.
The golang testing logging formatter does stack frame depth calculation to print out where the logging is from. If its redirected that breaks.
No description provided.