Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-container build support #2108

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Remove non-container build support #2108

merged 1 commit into from
Sep 24, 2024

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Sep 20, 2024

Requires #2106 merged first.

The aim here is to simplify the codebase so that it makes it easier to figure out what in the prebuild steps are needed and to convert them to yaml

@openshift-ci openshift-ci bot requested a review from vibe13 September 20, 2024 13:57
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.55%. Comparing base (aac3799) to head (45cfdaf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2108      +/-   ##
============================================
- Coverage     39.58%   39.55%   -0.03%     
  Complexity      812      812              
============================================
  Files           301      301              
  Lines         14087    13994      -93     
  Branches       1468     1468              
============================================
- Hits           5577     5536      -41     
+ Misses         7871     7821      -50     
+ Partials        639      637       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc rnc force-pushed the KJB12 branch 2 times, most recently from f3e46f0 to 2ed2d8c Compare September 23, 2024 10:07
@vibe13
Copy link
Member

vibe13 commented Sep 23, 2024

/lgtm

@vibe13
Copy link
Member

vibe13 commented Sep 23, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Sep 23, 2024
@rnc
Copy link
Collaborator Author

rnc commented Sep 23, 2024

/retest

@rnc rnc merged commit 1d8bf4f into redhat-appstudio:main Sep 24, 2024
26 checks passed
@rnc rnc deleted the KJB12 branch September 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants