Initialize struct with the correct number of members #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5ade1a (reddit#78) added two members to this struct, but only one to this initializer. This leads to undefined behaviour when rendering something like `#/u/test`, since the other callback functions are called through wrongly-typed function pointers. (It's my understanding that reddit doesn't use Snudown to render the ToC, and hence doesn't test this code path, but I'm surprised that compiler warnings about this were disabled [or ignored?])
|
Hi @erikdesjardins. Thanks for this patch. I'll ping someone who can review. |
|
@erikdesjardins are you depending on this code path, or just submitting this as cleanup? |
|
I do use this, but I already use a fork (where it's compiled to JS/wasm) so I don't depend on it being upstreamed. |
|
Yeah, we don't use the ToC renderer, but I don't recall seeing any warnings about it when I last looked. Might be a clang / GCC thing, or maybe it'd changed since then? Def a bug though. @birakattack ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b5ade1a (#78) added two members to this struct, but only one to this initializer.
This leads to undefined behaviour when rendering something like
#/u/test, since the other callback functions are called through wrongly-typed function pointers.(It's my understanding that reddit doesn't use Snudown to render the ToC, and hence doesn't test this code path, but I'm surprised that compiler warnings about this were disabled [or ignored?])