Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new version collector #28

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Use new version collector #28

merged 1 commit into from
Jun 4, 2024

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 15, 2024 •
edited by bjk-reddit
Loading

💸 TL;DR

Switch from deprecated Prometheus common to client_golang for version collector function.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@SuperQ SuperQ requested a review from a team as a code owner May 15, 2024 13:02
@bjk-reddit bjk-reddit requested a review from davinci26 May 15, 2024 13:03
@SuperQ SuperQ force-pushed the version_collector branch from e1afe90 to 21ec564 Compare June 3, 2024 15:21
@SuperQ
Use new version collector
3af29f2 
Switch from deprecated Prometheus common to client_golang for version
collector function.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the version_collector branch from 21ec564 to 3af29f2 Compare June 3, 2024 15:22
@bjk-reddit bjk-reddit merged commit 4dc650d into reddit:main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinci26 davinci26 davinci26 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperQ @davinci26 @bjk-reddit