-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prep for Linux, Windows, and Android support #1
base: main
Are you sure you want to change the base?
Conversation
@@ -55,7 +64,11 @@ public final class PapyrusStore { | |||
do { | |||
try self.createDirectoryIfNeeded(at: self.url) | |||
} catch { | |||
#if !os(Linux) && !os(Android) && !os(Windows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether it is cleaner to bring these checks inside the Logger class. So the Logger class decides whether to print or use os log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, Linux, Android, and Windows don't have os.log
, so it can't go directly in the logger. I'm not sure if those OS's have an equivalent logger
Conflicts: Papyrus/Source/PapyrusStore.swift
Not sure what's wrong with the SPM build as it builds locally, but I can't get it working in the CI, so I commented it out. As for Linux and Windows, you can see code needs to be updated to get build/test working here. I commented out Linux and Windows in the CI just incase you want to build test in the future. |
Hey @reddavis, just saw your framework earlier today on Swift Package Index and I think it's promising, great work!
I think this can be very useful for those who use ParseSwift.
Please have a look at this PR for preparing the project for adding Linux, Windows, and Android support. There are some methods used related to
DispatchSource
that won't allow for building on Linux, Windows, and Android. In the future if these become supported or if there are other methods used, this framework can work on those OS's.Let me know what you think...
Updates in this PR:
Combine
andLogger
functionality on Apple Platforms.Package.swift
, the tests pass locally for these. You might want to add builds for these in a future PRPackage.swift