-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI Patch Wizard #393
Open
EdwardLarson
wants to merge
35
commits into
redballoonsecurity:master
Choose a base branch
from
EdwardLarson:feature/gui_patch_wizard
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GUI Patch Wizard #393
EdwardLarson
wants to merge
35
commits into
redballoonsecurity:master
from
EdwardLarson:feature/gui_patch_wizard
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional serialized inputs
…ementing patch wizard backend
…f input, and to respect defaults and pre-existing bound values. Legacy SerializerInputForm.svelte left around, still used by non-patch-wizard components
…getting target binary symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add a step-by-step interface to the GUI to interactively configure a source code patch to a binary using PatchMaker.
Link to Related Issue(s)
The PatchFromSourceModifier and FunctionReplaceModifier can be run through the GUI to accomplish source code patching, but require the user to have some understanding of the goal beforehand. If anything goes wrong during these Modifiers' execution, the user has to inspect the OFRAK logs and possible temp build dirs to understand what step went wrong and how to correct the problem.
Please describe the changes in your request.
topLevelView
, is right now either the StartView, the normal resource tri-pane, ProjectManagerView, or RootWizardView. This change is not strictly necessary.SerializerInputForm
is split into multiple, more specific components, which cut down on the state that each type of serializer input requires reasoning about. Thanks to this, the serializer inputs now each all handle default inputs AND existing inputs - that is, if the serializer input is bound to variable X, and X already has a value, the serializer input is correctly prepopulated to reflect X.server.py
, I added amodules
directory with apatch_wizard.py
containing all the Patch Wizard functionality and routes, and a bit of code in the main server class constructor to add all the routes defined by a hardcoded list of modules (currently only the patch wizard).Anyone you think should look at this, specifically?
@rbs-jacob