Fix apktool and java CLI component check errors (#390)

redballoonsecurity · Oct 20, 2023 · 9fe4c85 · 9fe4c85
1 parent 6aa48f9
commit 9fe4c85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ofrak_core/CHANGELOG.md b/ofrak_core/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ## [Unreleased](https://github.com/redballoonsecurity/ofrak/tree/master)
 ### Fixed
 - Improved flushing of filesystem entries (including symbolic links and other types) to disk. ([#373](https://github.com/redballoonsecurity/ofrak/pull/373))
+- Fix `java` and `apktool` CLI arguments for checking components. ([#390](https://github.com/redballoonsecurity/ofrak/pull/390))
 
 ### Changed
 - `Resource.flush_to_disk` method renamed to `Resource.flush_data_to_disk`. ([#373](https://github.com/redballoonsecurity/ofrak/pull/373))

diff --git a/ofrak_core/ofrak/core/apk.py b/ofrak_core/ofrak/core/apk.py
@@ -22,11 +22,11 @@
 from ofrak_type.range import Range
 
 
-APKTOOL = ComponentExternalTool("apktool", "https://ibotpeaches.github.io/Apktool/", "--help")
+APKTOOL = ComponentExternalTool("apktool", "https://ibotpeaches.github.io/Apktool/", "-version")
 JAVA = ComponentExternalTool(
     "java",
     "https://openjdk.org/projects/jdk/11/",
-    "--help",
+    "-help",
     apt_package="openjdk-11-jdk",
     brew_package="openjdk@11",
 )