Move to multi-cluster controller with added resiliency of managed resources #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Signed-off-by: Umanga Chapagain <[email protected]>
Signed-off-by: Umanga Chapagain <[email protected]>
umangachapagain
force-pushed
the
multicluster-controller
branch
from
7611dad to
79c59a7
Compare
|
Found some design flaws with this approach. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, blue secret controller only watched for resources on local cluster and replicated it to the hub. In case the resource gets deleted on the hub, it would not be reconciled until a reconcile is triggered from the local cluster.
Similarly, green secret controller only watched resources on the hub and replicated it to local cluster. In case the resource gets deleted on the local cluster, it would not be reconciled until a reconcile is triggered from the hub cluster.
With this change, each of these controllers will watch for the resources that it creates on a different cluster and immediately reconciles in when a change is observed.