Initialize Mirroring spec to avoid nil pointer exception

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
red-hat-storage · Nov 26, 2024 · 88c6177 · 88c6177
1 parent 17353b7
commit 88c6177
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/addons/agent_mirrorpeer_controller.go b/addons/agent_mirrorpeer_controller.go
@@ -373,6 +373,9 @@ func (r *MirrorPeerReconciler) toggleMirroring(ctx context.Context, storageClust
 	}
 
 	// Determine if mirroring should be enabled or disabled
+	if sc.spec.Mirroring == nil {
+		sc.spec.Mirroring = &ocsv1.MirroringSpec{}
+	}
 	if enabled {
 		oppPeers := getOppositePeerRefs(mp, r.SpokeClusterName)
 		if hasRequiredSecret(sc.Spec.Mirroring.PeerSecretNames, oppPeers) {

diff --git a/addons/rook_secret_handler.go b/addons/rook_secret_handler.go
@@ -197,6 +197,9 @@ func updateStorageCluster(secretName, storageClusterName, storageClusterNamespac
 	}
 
 	// Update secret name
+	if sc.spec.Mirroring == nil {
+		sc.spec.Mirroring = &ocsv1.MirroringSpec{}
+	}
 	if !utils.ContainsString(sc.Spec.Mirroring.PeerSecretNames, secretName) {
 		sc.Spec.Mirroring.PeerSecretNames = append(sc.Spec.Mirroring.PeerSecretNames, secretName)
 		err := spokeClient.Update(ctx, sc)