[DowngradePhp84] Add DowngradeNewMethodCallWithoutParenthesesRector #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
It seems allow constant, static property, static method, property, invoke, array array dim fetch as well based on https://wiki.php.net/rfc/new_without_parentheses I think we can use this MethodCall as starting point, add more nodes later. |
|
👍 |
|
@TomasVotruba let's merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To downgrade new method call without parentheses for php 8.4 https://wiki.php.net/rfc/new_without_parentheses
Ref to allow feature rectorphp/rector#8701, the downgrade rule need to exists on the first place.