feat: add copy_*e_to_slice family
#423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Dec 25, 2024
prestwich
force-pushed
the
prestwich/copy-to-buf
branch
from
ab04803 to
60147b0
Compare
prestwich
force-pushed
the
prestwich/copy-to-buf
branch
from
55c7ef2 to
4bd34e1
Compare
DaniPopes
approved these changes
Dec 27, 2024
src/support/borsh.rs
Outdated
| let bytes = self.as_le_bytes(); | ||
| writer.write_all(&bytes[..Self::BYTES]) | ||
| #[cfg(target_endian = "little")] | ||
| return writer.write_all(&self.as_le_slice()[..Self::BYTES]); |
There was a problem hiding this comment.
Suggested change
| return writer.write_all(&self.as_le_slice()[..Self::BYTES]); | |
| return writer.write_all(self.as_le_slice()); |
prestwich
force-pushed
the
prestwich/copy-to-buf
branch
from
b6c3d74 to
45d2694
Compare
Evalir
approved these changes
Dec 30, 2024
| #[cfg(target_endian = "little")] | ||
| return writer.write_all(self.as_le_slice()); | ||
|
|
||
| // TODO: Replace the unsafety with `generic_const_exprs` when |
There was a problem hiding this comment.
do we have an issue for this filed?
There was a problem hiding this comment.
The actions bot will auto file it when the PR is merged
3 tasks
|
closing in favor of #424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add convenient methods for writing Uints to pre-allocated buffers
Solution
PR Checklist