Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Subtle and DER. #399

Merged
merged 14 commits into from
Nov 4, 2024
Merged

Add support for Subtle and DER. #399

merged 14 commits into from
Nov 4, 2024

Conversation

recmo
Copy link
Owner

@recmo recmo commented Oct 14, 2024

Motivation

Makes it easier to use UInts for implementing cryptographic protocols.

Solution

PR Checklist

  • Added Tests
  • Add support for conversion from der::asn1 any/int formats
  • Added Documentation
  • Updated the changelog

@recmo recmo requested a review from prestwich as a code owner October 14, 2024 10:33
@recmo recmo marked this pull request as draft October 14, 2024 10:34
@recmo recmo marked this pull request as ready for review October 14, 2024 14:40
@prestwich
Copy link
Collaborator

let me know when this is ready for review 👍

@recmo
Copy link
Owner Author

recmo commented Nov 1, 2024

@prestwich Ready for review!

@recmo recmo enabled auto-merge November 1, 2024 06:14
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly no_std compilation related changes

src/support/der.rs Outdated Show resolved Hide resolved
src/support/der.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@recmo
Copy link
Owner Author

recmo commented Nov 4, 2024

@prestwich Please review!

I did look briefly in adding a 'does it build in no_std' step to the CI, but it seems that as of today there are still no good solutions to test this. But the clippy lint I added should cover the majority of problems.

@prestwich
Copy link
Collaborator

yeah, we are currently relying on the cargo hack CI step to do a large number of --no-default-features recompilations and it is definitely not sufficient

last outstanding item is to qualify or import Box in der.rs. then this looks good to go

cargo check --no-default-features --features der

@recmo recmo merged commit b81aa0a into main Nov 4, 2024
17 checks passed
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@recmo recmo deleted the recmo/der branch November 4, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants