feature: more Shl+Shr impls #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
added
enhancement
prestwich
force-pushed
the
prestwich/shift
branch
from
dad200a to
95dc182
Compare
gakonst
approved these changes
Oct 3, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 80.78% 80.45% -0.34%
==========================================
Files 54 54
Lines 6111 6053 -58
==========================================
- Hits 4937 4870 -67
- Misses 1174 1183 +9
☔ View full report in Codecov by Sentry. |
DaniPopes
approved these changes
Oct 3, 2023
src/bits.rs
Outdated
| self.wrapping_shr(*rhs) | ||
| } | ||
| } | ||
| impl_shift!(usize, u8, u16, u32, i8, i16, i32, isize); |
Evalir
approved these changes
Oct 4, 2023
DaniPopes
reviewed
Oct 4, 2023
Comment on lines
+703
to
+705
| // Only when losslessy castable to usize. | ||
| #[cfg(target_pointer_width = "64")] | ||
| impl_shift!(u64, i64); |
There was a problem hiding this comment.
below is lossless too, it just pads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #327
Solution
Add Shl and Shr implementations for types that are losslessly castable to usize by re-using the existing
usizeimplementationPR Checklist