Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

Use the sound settings from the configuration file #667

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Use the sound settings from the configuration file #667

wants to merge 8 commits into from

Conversation

redbug26
Copy link

Changes :

  • Use the sound settings from the configuration file

Use the sound settings from the configuration file
@substring
Copy link
Contributor

I love it !! I'll review that tomorrow :)

@substring
Copy link
Contributor

At S02, we don't know yet which is the device that will be mounted on /recalbox/share, so users with a USB key or CIFS won't see their volume adjusted according to their setting. Sadly, that's something we can't solve easily,. Which means @redbug26 you came with the right solution !

Changing the audio output device is a great idea !

substring
substring previously approved these changes Feb 23, 2017
@rockaddicted
Copy link
Member

Hi and thank you for your PR.
Could be awesome to also check this option audio.bgmusic=1 (or a new one like audio.splashmusic=1) to totally disable sound of splashscreen.

What do you think about that ?

@nadenislamarre
Copy link
Contributor

at s02, you've no access to /recalbox/share/system/recalbox.conf too even when using internal devices, not only usb keys.

@redbug26
Copy link
Author

True...
What do you think about a script that modify the S02splash file when you shutdown the raspberry ?
It could be easily done too.

@substring
Copy link
Contributor

You do not edit an init script ! Updates would erase changes !
2 solutions :

  • store volume in /boot
  • store volume in /

/boot looks like the best choice, in recalbox-boot.conf for ex. @digitalLumberjack any opinion ?

@digitalLumberjack
Copy link
Member

Yep @substring recalbox-boot.conf seems to be the best solution but /boot is not mounted when S02 runs.
And we won't modify /.

@redbug26
Copy link
Author

Thus ?

On ne fait rien et on laisse comme ça ? :-)

@digitalLumberjack
Copy link
Member

No we can try to move the boot mount before the splashscreen :)

@substring
Copy link
Contributor

Problem : S04boot won't be erased (yet) on upgrade to 4.1 ...

@substring
Copy link
Contributor

@redbug26 have you read /etc/init.d/rcK? ;)
And we "prefer" using python for reading the recalbox.conf, that's how it's done in all other scripts

@@ -0,0 +1,26 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our init uses the stop parameter, not K-prefixed scripts

@redbug26
Copy link
Author

It was just some new tests on my repo :-)
I'll look for the stop parameters and the python things tonight.
Thanks for your return

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants