WIP: Compiler and linker detection for the C++ plugin. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++ compiler in use is now detected; vendor-specific compiler flags are now supported for C++ files. C++ file's output now also depends on the compiler (so if you update the compiler, everything will be rebuilt) and on the exact command line used to build it; this, together with the fact that $CXXFLAGS is used in the command line, means that changing that environment variable prompts a rebuild. At some point in the future I'll probably introduce a mode that fixes the contents of CXXFLAGS from the first build that happens for an output directory, plus some additional caching (like not having to respecify the compiler via CXX), but it's not a priority right now.
griwes
changed the title
Also the dependency on the compiler isn't only on the exact path that is used, but also on all the symlinks along the way. I wonder whether this same approach should also be used for other dependencies, but let's ignore this for now.
griwes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will solve #3 and #10 once completed.