Remove raise annotations and fix locations on errors #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
changed the title
jchavarri
reviewed
Nov 20, 2024
davesnx
force-pushed
the
remove-raises-as-annotations
branch
from
9857fc3
to
55071e6
Compare
|
Made it depend on #main @jchavarri Deleted the test that ensures ref works, since it come in #846 (and depends on ReactTestingLibrary dependency) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #862 that depends on #859, that depends on #846
Minimalist and spiritual successor of #848
Fix #843
Took the chance to cleanup all
raise Invalid_argumentintoLocation.raise_errorf(which isn't ideal from the ppxlib standpoint, since it fails a Parseetree generation and only shows one error) but the refactor to this is massive