Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install melange 1.0 #757

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Install melange 1.0 #757

merged 5 commits into from
Aug 3, 2023

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Aug 2, 2023

This PR unpins melange from dev and allows to publish new versions of reason-react while new versions of Melange aren't published.

The change is on not using deriving abstract and using bs.deriving abstract on makeProps

@davesnx davesnx marked this pull request as ready for review August 3, 2023 09:23
@davesnx davesnx changed the base branch from main to melange-v1 August 3, 2023 16:28
@davesnx davesnx merged commit d958c23 into melange-v1 Aug 3, 2023
2 of 4 checks passed
davesnx added a commit that referenced this pull request Aug 3, 2023
davesnx added a commit that referenced this pull request Aug 3, 2023
* 'main' of github.com:/reasonml/reason-react:
  Install melange 1.0 (#757) (#758)
anmonteiro added a commit that referenced this pull request Aug 12, 2023
anmonteiro added a commit that referenced this pull request Sep 6, 2023
davesnx added a commit that referenced this pull request Sep 6, 2023
…-test-for-inference-regression

* 'main' of github.com:/reasonml/reason-react:
  Allow memoCustomCompareProps on ppx (#766)
  Fix rules for reason under with-test (#762)
  fix opam formula (#763)
  depexts: expand to react 17 (#761)
  add npm depexts (#760)
  Create a blog entry for 0.11 and Melange (#743)
  Install melange 1.0 (#757) (#758)
anmonteiro added a commit that referenced this pull request Sep 8, 2023
anmonteiro added a commit that referenced this pull request Sep 10, 2023
anmonteiro added a commit that referenced this pull request Sep 13, 2023
anmonteiro added a commit that referenced this pull request Sep 14, 2023
* Revert "Install melange 1.0 (#757) (#758)"

This reverts commit 684ffac.

* feat: migrate from `bs.*` to `mel.*` attributes (#755)

* feat: migrate from `bs.*` to `mel.*` attributes

* melange2: remove mel.val

* update tests

* ci: update opam to use 5.1.x

* add melange.dom to libraries

* test(ci): fix flakes / OCaml version / add melange.dom

* rm dupe

---------

Co-authored-by: Javier Chavarri <[email protected]>

* fix tests

* fix opam constraints

* wip

* update flake

* try OCaml 5.1.x

* merlin

---------

Co-authored-by: Javier Chavarri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant