Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup a few websocket things #3625

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Cleanup a few websocket things #3625

merged 1 commit into from
Jun 24, 2024

Conversation

nirinchev
Copy link
Member

Description

Fixes #

TODO

  • Changelog entry
  • Tests

@cla-bot cla-bot bot added the cla: yes label Jun 17, 2024
@nirinchev nirinchev requested review from fealebenpae and papafe June 17, 2024 21:55
@nirinchev nirinchev added no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference labels Jun 17, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9555296703

Details

  • 0 of 36 (0.0%) changed or added relevant lines in 3 files are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 81.371%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Native/SyncSocketProvider.EventLoop.cs 0 8 0.0%
Realm/Realm/Native/SyncSocketProvider.cs 0 11 0.0%
Realm/Realm/Native/SyncSocketProvider.WebSocket.cs 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Configurations/RealmConfiguration.cs 1 92.68%
Realm/Realm/Native/SyncSocketProvider.cs 1 0.0%
Realm/Realm/Configurations/RealmConfigurationBase.cs 4 95.35%
Realm/Realm/Handles/SharedRealmHandle.cs 10 92.56%
Totals Coverage Status
Change from base Build 9508907428: 0.1%
Covered Lines: 6831
Relevant Lines: 8243
💛 - Coveralls

@nirinchev nirinchev merged commit 925b373 into main Jun 24, 2024
76 of 82 checks passed
@nirinchev nirinchev deleted the ni/websocket-cleanup branch June 24, 2024 17:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae Awaiting requested review from fealebenpae

@papafe papafe Awaiting requested review from papafe

Assignees

@nirinchev nirinchev

Labels
cla: yes no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nirinchev