Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t use KeyValuePair in marshaling because it’s overloaded on UWP #3435

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Don’t use KeyValuePair in marshaling because it’s overloaded on UWP #3435

merged 1 commit into from
Sep 5, 2023

Conversation

fealebenpae
Copy link
Member

Description

Use our own struct for marshaling instead of using System.KeyValuePair<TKey, TValue>.

Fixes #3434

  • Changelog entry
  • Tests (if applicable)

@fealebenpae fealebenpae self-assigned this Sep 4, 2023
@cla-bot cla-bot bot added the cla: yes label Sep 4, 2023
@fealebenpae fealebenpae merged commit 5b1a7c2 into main Sep 5, 2023
67 of 68 checks passed
@fealebenpae fealebenpae deleted the yg/kvp-marshaling branch September 5, 2023 02:35
nirinchev added a commit that referenced this pull request Sep 15, 2023
@nirinchev
Merge branch 'main' into ni/user-changed
576d88f 
* main:
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)
  Don’t use KeyValuePair in marshaling because it’s overloaded on UWP (#3435)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

Assignees

@fealebenpae fealebenpae

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realm 11.4.0 fails with ilc compilation issue on UWP when building the app in the release mode
2 participants
@fealebenpae @nirinchev