Workflow update and package clean-up (#24)

realitycollective · May 8, 2024 · a3f3b4d · a3f3b4d
1 parent a701c46
commit a3f3b4d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/.github/workflows/development-buildandtestupmrelease.yml b/.github/workflows/development-buildandtestupmrelease.yml
@@ -38,4 +38,11 @@ jobs:
     with:
       unityversion: ${{ needs.Validate-Unity.outputs.unityeditorversion }}
       dependencies: '[{"development": "github.com/realitycollective/com.realitycollective.buildtools.git"},{"development": "github.com/realitycollective/com.realitytoolkit.core.git"},{"development": "github.com/realitycollective/com.realitycollective.utilities.git"},{"development": "github.com/realitycollective/com.realitytoolkit.service-framework.git"}]'
-    secrets: inherit
+    secrets: inherit
+
+  Build-Complete:
+    runs-on: ubuntu-latest
+    name: Build completion task
+    needs: Run-Unit-Tests
+    steps: 
+      - run: echo "Build Complete"
diff --git a/Editor/SpatialPersistencePackageInstaller.cs b/Editor/SpatialPersistencePackageInstaller.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Reality Collective. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-using RealityCollective.ServiceFramework;
 using RealityCollective.ServiceFramework.Editor;
 using RealityCollective.ServiceFramework.Editor.Packages;
 using RealityCollective.Utilities.Editor;
@@ -44,4 +43,4 @@ private static void CheckPackage()
             }
         }
     }
-}
+}
diff --git a/Editor/SpatialPersistencePackageModulesInstaller.cs b/Editor/SpatialPersistencePackageModulesInstaller.cs
@@ -19,7 +19,7 @@ namespace RealityToolkit.SpatialPersistence.Editor
     public sealed class SpatialPersistencePackageModulesInstaller : IPackageModulesInstaller
     {
         /// <summary>
-        /// Statis initalizer for the installer instance.
+        /// Static initializer for the installer instance.
         /// </summary>
         static SpatialPersistencePackageModulesInstaller()
         {
@@ -80,4 +80,4 @@ public bool Install(ServiceConfiguration serviceConfiguration)
             return true;
         }
     }
-}
+}
diff --git a/Editor/SpatialPersistencePackagePathFinder.cs b/Editor/SpatialPersistencePackagePathFinder.cs
@@ -15,4 +15,4 @@ public class SpatialPersistencePackagePathFinder : ScriptableObject, IPathFinder
         /// <inheritdoc />
         public string Location => $"/Editor/{nameof(SpatialPersistencePackagePathFinder)}.cs";
     }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up @@
             /// <inheritdoc />
             public string Location => $"/Editor/{nameof(SpatialPersistencePackagePathFinder)}.cs";
         }
-    }
+    }