Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate namespaces to the new utilities / SF structure #6

Merged
merged 3 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/development-buildandtestupmrelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,11 @@ jobs:
with:
unityversion: ${{ needs.Validate-Unity.outputs.unityeditorversion }}
dependencies: '[{"development": "github.com/realitycollective/com.realitycollective.buildtools.git"},{"development": "github.com/realitycollective/com.realitytoolkit.spatial-persistence.git"},{"development": "github.com/realitycollective/com.realitytoolkit.core.git"},{"development": "github.com/realitycollective/com.realitycollective.utilities.git"},{"development": "github.com/realitycollective/com.realitytoolkit.service-framework.git"}]'
secrets: inherit
secrets: inherit

Build-Complete:
runs-on: ubuntu-latest
name: Build completion task
needs: Run-Unit-Tests
steps:
- run: echo "Build Complete"
9 changes: 9 additions & 0 deletions Editor/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using System.Reflection;

[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyTitle("com.realitytoolkit.spatialpersistence.arfoundation.editor")]
[assembly: AssemblyCompany("Reality Collective")]
[assembly: AssemblyCopyright("Copyright (c) Reality Collective. All rights reserved.")]
2 changes: 2 additions & 0 deletions Editor/AssemblyInfo.cs.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions Editor/SpatialPersistence_ARFoundationPackageInstaller.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Editor.Utilities;
using RealityCollective.Extensions;
using RealityCollective.ServiceFramework;
using RealityCollective.ServiceFramework.Editor;
using RealityCollective.ServiceFramework.Editor.Packages;
using RealityCollective.Utilities.Editor;
using RealityCollective.Utilities.Extensions;
using System.IO;
using UnityEditor;
using UnityEngine;
Expand Down Expand Up @@ -44,4 +43,4 @@ private static void CheckPackage()
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ public bool Install(ServiceConfiguration serviceConfiguration)
return true;
}
}
}
}
2 changes: 1 addition & 1 deletion Editor/SpatialPersistence_ARFoundationPathFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ public class SpatialPersistence_ARFoundationPackagePathFinder : ScriptableObject
/// <inheritdoc />
public string Location => $"/Editor/{nameof(SpatialPersistence_ARFoundationPackagePathFinder)}.cs";
}
}
}
9 changes: 9 additions & 0 deletions Runtime/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using System.Reflection;

[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyTitle("com.realitytoolkit.spatialpersistence.arfoundation")]
[assembly: AssemblyCompany("Reality Collective")]
[assembly: AssemblyCopyright("Copyright (c) Reality Collective. All rights reserved.")]
2 changes: 2 additions & 0 deletions Runtime/AssemblyInfo.cs.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Runtime/Modules/ARFoundationDynamicLibraryManager.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Extensions;
using RealityCollective.Utilities;
using RealityCollective.Utilities.Extensions;
using RealityCollective.Utilities.Logging;
using RealityToolkit.SpatialPersistence.Definitions;
using System;
using System.Collections;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Extensions;
using RealityCollective.Utilities.Extensions;
using RealityCollective.Utilities.Async;
using RealityToolkit.SpatialPersistence.ARFoundation.Definitions;
using RealityToolkit.SpatialPersistence.ARFoundation.Extensions;
using RealityToolkit.SpatialPersistence.Definitions;
using RealityToolkit.SpatialPersistence.Interfaces;
using System;
Expand Down Expand Up @@ -37,7 +36,11 @@ private ARTrackedImageManager TrackedImageManager
if (trackedImageManager == null)
{
// Get a reference to the SpatialAnchorManager component (must be on the same gameobject)
#if UNITY_2023_1_OR_NEWER
trackedImageManager = GameObject.FindFirstObjectByType<ARTrackedImageManager>();
#else
trackedImageManager = GameObject.FindObjectOfType<ARTrackedImageManager>();
#endif
if (trackedImageManager.IsNull())
{
var message = $"Unable to locate the {typeof(ARTrackedImageManager)} in the scene, service cannot initialize";
Expand All @@ -55,7 +58,11 @@ private ARFoundationDynamicLibraryManager DynamicLibraryManager
if (dynamicLibraryManager == null)
{
// Get a reference to the SpatialAnchorManager component (must be on the same gameobject)
#if UNITY_2023_1_OR_NEWER
dynamicLibraryManager = GameObject.FindFirstObjectByType<ARFoundationDynamicLibraryManager>();
#else
dynamicLibraryManager = GameObject.FindObjectOfType<ARFoundationDynamicLibraryManager>();
#endif
if (dynamicLibraryManager.IsNull())
{
if (TrackedImageManager.IsNull())
Expand Down
2 changes: 1 addition & 1 deletion Runtime/Modules/ARFoundationTrackableImagesLibrary.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Extensions;
using RealityCollective.Utilities.Extensions;
using RealityToolkit.SpatialPersistence.Definitions;
using System;
using System.Linq;
Expand Down
9 changes: 9 additions & 0 deletions Tests/Editor/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using System.Reflection;

[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyTitle("com.realitytoolkit.spatialpersistence_arfoundation.editor.tests")]
[assembly: AssemblyCompany("Reality Collective")]
[assembly: AssemblyCopyright("Copyright (c) Reality Collective. All rights reserved.")]
2 changes: 2 additions & 0 deletions Tests/Editor/AssemblyInfo.cs.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions Tests/Runtime/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using System.Reflection;

[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyTitle("com.realitytoolkit.spatialpersistence_arfoundation.tests")]
[assembly: AssemblyCompany("Reality Collective")]
[assembly: AssemblyCopyright("Copyright (c) Reality Collective. All rights reserved.")]
2 changes: 2 additions & 0 deletions Tests/Runtime/AssemblyInfo.cs.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"com.unity.xr.arfoundation": "5.1.0",
"com.realitytoolkit.spatial-persistence": "1.0.0-pre.5"
"com.realitytoolkit.spatial-persistence": "1.0.1"
},
"assets": [
{
Expand Down
Loading