Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest core #19

Merged
merged 4 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Editor/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using System.Reflection;

[assembly: AssemblyVersion("1.0.3")]
[assembly: AssemblyTitle("com.realitytoolkit.devtools.editor")]
[assembly: AssemblyCompany("Reality Collective")]
[assembly: AssemblyCopyright("Copyright (c) Reality Collective. All rights reserved.")]
11 changes: 11 additions & 0 deletions Editor/AssemblyInfo.cs.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions Editor/DevToolsPackageInstaller.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
// Copyright (c) Reality Collective. All rights reserved.
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Editor.Utilities;
using RealityCollective.Extensions;
using RealityCollective.ServiceFramework.Editor;
using RealityCollective.ServiceFramework.Editor.Packages;
using RealityCollective.Utilities.Editor;
using RealityCollective.Utilities.Extensions;
using RealityToolkit.Editor;
using RealityToolkit.Editor.Settings;
using System.IO;
using UnityEditor;

Expand All @@ -14,7 +15,7 @@ namespace RealityToolkit.DevTools.Editor
[InitializeOnLoad]
internal static class DevToolsPackageInstaller
{
private static readonly string destinationPath = $"{RealityToolkitPreferences.ProfileGenerationPath}DeveloperTools";
private static readonly string destinationPath = Path.Combine(RealityToolkitEditorSettings.Instance.AssetImportPath, "DeveloperTools");
private static readonly string sourcePath = Path.GetFullPath($"{PathFinderUtility.ResolvePath<IPathFinder>(typeof(DevToolsPackagePathFinder)).ForwardSlashes()}{Path.DirectorySeparatorChar}{RealityToolkitPreferences.HIDDEN_PACKAGE_ASSETS_PATH}");

static DevToolsPackageInstaller()
Expand Down
3 changes: 2 additions & 1 deletion Editor/RealityToolkit.DevTools.Editor.asmdef
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"GUID:2a3f0ca4e21332c44bfdce311ea8943e",
"GUID:810ca3bc28e810c44ac144b708fca7f4",
"GUID:13703f41b24bb904cb2305abe6317e3d",
"GUID:9753fcbb5b1feaf459f435ac95e51baa"
"GUID:9753fcbb5b1feaf459f435ac95e51baa",
"GUID:4ddd23ea56a3a40f0aa0036d1624a53e"
],
"includePlatforms": [
"Editor"
Expand Down
9 changes: 9 additions & 0 deletions Runtime/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using System.Reflection;

[assembly: AssemblyVersion("1.0.3")]
[assembly: AssemblyTitle("com.realitytoolkit.devtools")]
[assembly: AssemblyCompany("Reality Collective")]
[assembly: AssemblyCopyright("Copyright (c) Reality Collective. All rights reserved.")]
11 changes: 11 additions & 0 deletions Runtime/AssemblyInfo.cs.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Runtime/BaseDiagnosticsEventData.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Utilities.Extensions;
using System;
using UnityEngine.EventSystems;
using RealityCollective.Extensions;

namespace RealityToolkit.DevTools
{
Expand Down
2 changes: 1 addition & 1 deletion Runtime/ConsoleDiagnostics/ConsoleDiagnosticsHandler.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Attributes;
using RealityCollective.Utilities.Attributes;
using System;
using TMPro;
using UnityEngine;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,17 @@ public ConsoleDiagnosticsServiceModule(string name, uint priority, BaseProfile p
}

/// <inheritdoc />
public override void Enable()
public override void Start()
{
base.Enable();

if (DiagnosticsService != null)
{
Application.logMessageReceived += DiagnosticsService.RaiseLogReceived;
}
}

/// <inheritdoc />
public override void Disable()
public override void Destroy()
{
base.Disable();

if (DiagnosticsService != null)
{
Application.logMessageReceived -= DiagnosticsService.RaiseLogReceived;
Expand Down
37 changes: 9 additions & 28 deletions Runtime/DiagnosticsService.cs
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Definitions.Utilities;
using RealityCollective.Extensions;
using RealityCollective.ServiceFramework.Attributes;
using RealityCollective.ServiceFramework.Definitions.Platforms;
using RealityCollective.ServiceFramework.Definitions.Utilities;
using RealityCollective.ServiceFramework.Services;
using RealityCollective.Utilities.Extensions;
using RealityToolkit.DevTools.ConsoleDiagnostics;
using RealityToolkit.DevTools.FrameDiagnostics;
using RealityToolkit.DevTools.MemoryDiagnostics;
using RealityToolkit.Player.Interfaces;
using RealityToolkit.Player;
using UnityEngine;
using UnityEngine.EventSystems;
using Object = UnityEngine.Object;
Expand Down Expand Up @@ -71,17 +71,6 @@ public override void Initialize()
frameEventData = new FrameEventData(currentEventSystem);
consoleEventData = new ConsoleEventData(currentEventSystem);
memoryEventData = new MemoryEventData(currentEventSystem);
}

/// <inheritdoc />
public override void Enable()
{
base.Enable();

if (!Application.isPlaying)
{
return;
}

if (profile.ShowDiagnosticsWindowOnStart == AutoStartBehavior.AutoStart)
{
Expand All @@ -90,24 +79,13 @@ public override void Enable()
}

/// <inheritdoc />
public override void Disable()
public override void Destroy()
{
base.Disable();

if (!Application.isPlaying) { return; }

if (diagnosticsWindow != null)
if (diagnosticsWindow.IsNotNull())
{
Unregister(diagnosticsWindow);
}

}

/// <inheritdoc />
public override void Destroy()
{
base.Destroy();

diagnosticsWindow.Destroy();

if (!diagnosticsRoot.IsNull() &&
Expand Down Expand Up @@ -166,7 +144,10 @@ public bool IsWindowEnabled
get => DiagnosticsWindow.activeInHierarchy && isWindowEnabled;
set
{
if (isWindowEnabled == value) { return; }
if (isWindowEnabled == value)
{
return;
}

isWindowEnabled = value;
DiagnosticsWindow.SetActive(isWindowEnabled);
Expand Down
6 changes: 3 additions & 3 deletions Runtime/DiagnosticsServiceProfile.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Copyright (c) Reality Collective. All rights reserved.
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Attributes;
using RealityCollective.Definitions.Utilities;
using RealityCollective.ServiceFramework.Definitions;
using RealityCollective.ServiceFramework.Definitions.Utilities;
using RealityCollective.Utilities.Attributes;
using UnityEngine;

namespace RealityToolkit.DevTools
Expand Down
2 changes: 1 addition & 1 deletion Runtime/FrameDiagnostics/FrameDiagnosticsHandler.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Reality Collective. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using RealityCollective.Attributes;
using RealityCollective.Utilities.Attributes;
using System.Collections.Generic;
using System.Globalization;
using System.Text;
Expand Down
6 changes: 1 addition & 5 deletions Runtime/FrameDiagnostics/FrameDiagnosticsServiceModule.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,8 @@ private int DeviceTargetRefreshRate
#region IService Implementation

/// <inheritdoc />
public override void Enable()
public override void Start()
{
base.Enable();

if (!Application.isPlaying) { return; }

stopwatch.Restart();
}

Expand Down
23 changes: 15 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,20 @@
"name": "com.realitytoolkit.devtools",
"displayName": "RealityToolkit.DevTools",
"description": "A collection of services, utilities and tools useful for developing immersive experiences using the Reality Toolkit.",
"version": "1.0.3-pre.1",
"documentationUrl": "https://realitytoolkit.realitycollective.net/",
"changelogUrl": "https://github.com/realitycollective/com.realitytoolkit.devtools/releases",
"licensesUrl": "https://github.com/realitycollective/com.realitytoolkit.devtools/blob/main/LICENSE.md",
"keywords": [
"VR",
"AR",
"XR",
"Mixed Reality"
],
"version": "1.0.3-pre.1",
"unity": "2021.3",
"homepage": "https://github.com/realitycollective",
"unity": "2022.3",
"homepage": "https://realitytoolkit.realitycollective.net/",
"bugs": {
"url": "https://github.com/realitycollective/realitytoolkit.dev/issues"
"url": "https://github.com/realitycollective/com.realitytoolkit.devtools/issues"
},
"license": "MIT",
"repository": {
Expand All @@ -24,15 +27,19 @@
"email": "[email protected]",
"url": "https://github.com/realitycollective"
},
"publishConfig": {
"registry": "https://package.openupm.com"
},
"dependencies": {
"com.realitytoolkit.core": "1.0.0-pre.37",
"com.realitytoolkit.player": "1.0.3-pre.1",
"com.unity.ugui": "1.0.0"
"com.realitytoolkit.core": "1.0.0-pre.48",
"com.realitytoolkit.player": "1.0.4",
"com.unity.ugui": "1.0.0",
"com.unity.textmeshpro": "3.0.8"
},
"assets": [
{
"displayName": "Default Assets",
"path": "Assets~/"
}
]
}
}