Merge pull request #14 from realitycollective/dev/update-core

Update core

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,33 @@
+---
+name: Bug Report
+about: Create a report to identify a potential issue
+title: '[BUG]'
+labels: bug
+assignees: '@FejZa'
+---
+
+# Reality Toolkit - Bug Report
+
+## Describe The Bug
+
+<!-- Please provide a clear and concise description of what the bug is. -->
+
+## Steps To Reproduce
+
+<!-- Include Steps to reproduce the behavior. -->
+
+## Expected Behavior
+
+<!--  A clear and concise description of what you expected to happen. -->
+
+## Actual Behavior
+
+<!-- What is actually happening. -->
+
+## Environment
+
+<!-- Unity Version, Reality Toolkit package versions, Target devices... -->
+
+## Additional Information
+
+<!-- If applicable, add screenshots, stacktraces to help explain your problem. -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature Request
+about: Suggest an idea for the Reality Toolkit's locomotion package
+title: '[FEATURE REQUEST]'
+labels: enhancement
+assignees: '@FejZa'
+---
+
+# Reality Toolkit - Feature Request
+
+## Feature Description
+
+<!--Please provide a clear and concise description of what you are suggesting and what problem it solves -->
+
+## Implementation
+
+<!--If you have suggestions on how to implement this feature, please provide them here -->

.github/ISSUE_TEMPLATE/request_for_information.md

@@ -0,0 +1,17 @@
+---
+name: Request For Information
+about: Not sure how to do something? Just ask
+title: '[QUESTION]'
+labels: question
+assignees: '@FejZa'
+---
+
+# Reality Toolkit - Request For Information
+
+## What Are You Trying To Achieve?
+
+<!-- Add a clear and concise description of what is it you are trying to implement or need information about. Include screenshots or examples from other projects if it helps. -->
+
+## What Have You Already Tried?
+
+<!-- Have you tried to complete the task yourself but couldn't figure it out, if so what and why? -->

README.md

@@ -13,23 +13,49 @@ A collection of services, utilities and tools for simulating XR devices when wor
 
 Make sure to always use the same source for all toolkit modules. Avoid using different installation sources within the same project. We provide the following ways to install Reality Toolkit modules:
 
-### Method 1: Using Package Manager for git users
+### Method 1: OpenUPM CLI
 
-1. Open the Package Manager using the Window menu -> Package Manager
-
-2. Inside the Package Manager, click on the "+" button on the top left and select "Add package from git URL..."
-
-3. Input the following URL: https://github.com/realitycollective/com.realitytoolkit.devicesimulation.git and click "Add".
-
-### Method 2: OpenUPM
+This method requires the [OpenUPM CLI](https://openupm.com/#get-started-with-cli-optional) to be installed on your computer.
 
 ```text
     openupm add com.realitytoolkit.devicesimulation
 ```
 
-### Method 3: Unity Asset Store
+### Method 2: OpenUPM Scoped Registry
+
+If you do not wish to use the [OpenUPM CLI](https://openupm.com/#get-started-with-cli-optional) you can also manually add the OpenUPM registry to your project and browse all available toolkit packages.
+
+1. Open the [Project Settings](https://docs.unity3d.com/Manual/comp-ManagerGroup.html) window.
+
+2. Select the **Package Manager** settings category to the left.
+
+3. Add a new scoped registry
+   1. Name: **OpenUPM**
+   2. URL: **https://package.openupm.com**
+   3. Scopes: **com.realitycollective** and **com.realitytoolkit**
+   4. Press **Save** 
+
+![Add Scoped Registry](https://github.com/realitycollective/realitycollective.logo/blob/main/RealityToolkit/ReadmeAssets/add-scoped-registry.png?raw=true)
+
+4. Open the [Package Manager](https://docs.unity3d.com/Manual/Packages.html) window.
+
+5. In the top left packages filter dropdown select **My Registries**.
+
+6. You'll now see all published toolkit packages listed for you to install.
+
+![Add Scoped Registry](https://github.com/realitycollective/realitycollective.logo/blob/main/RealityToolkit/ReadmeAssets/package-manager-registry.png?raw=true)
+
+### Method 3: Using Package Manager for git users
+
+1. Open the [Package Manager](https://docs.unity3d.com/Manual/Packages.html) through this menu: **Window -> Package Manager**.
+
+2. Inside the [Package Manager](https://docs.unity3d.com/Manual/Packages.html), click on the **+** button on the top left and select **Add package from git URL...**.
+
+3. Input the following URL: https://github.com/realitycollective/com.realitytoolkit.devicesimulation.git and click **Add**.
+
+### Method 4: Unity Asset Store
 
-This option will be available soon.
+We are working on making the Reality Toolkit available via the Unity asset store and will share news, once available.
 
 ## Getting Started
 

Runtime/InputService/BaseSimulatedControllerServiceModule.cs

@@ -93,9 +93,9 @@ protected BaseSimulatedControllerServiceModule(string name, uint priority, Simul
         public float RotationSpeed { get; }
 
         /// <inheritdoc />
-        public override void Enable()
+        public override void Start()
         {
-            base.Enable();
+            base.Start();
 
             simulatedUpdateStopWatch = new StopWatch();
             simulatedUpdateStopWatch.Reset();
@@ -116,10 +116,10 @@ public override void Update()
         }
 
         /// <inheritdoc />
-        public override void Disable()
+        public override void Destroy()
         {
             RemoveAllControllers();
-            base.Disable();
+            base.Destroy();
         }
 
         private void RefreshSimulatedDevices()

package.json

@@ -31,13 +31,13 @@
     "registry": "https://package.openupm.com"
   },
   "dependencies": {
-    "com.realitytoolkit.core": "1.0.0-pre.48",
-    "com.realitytoolkit.player": "1.0.4"
+    "com.realitytoolkit.core": "1.0.0-pre.50",
+    "com.realitytoolkit.player": "1.0.5-pre.6"
   },
   "assets": [
     {
       "displayName": "Default Assets",
       "path": "Assets~/"
     }
   ]
-}
+}