Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Track pointer down and raise pointer up on previously downed targets #98

Merged
merged 12 commits into from
Nov 10, 2023

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Nov 10, 2023

Reality Collective - Reality Toolkit Pull Request

Overview

This PR is a hotfix to the problem where a target (Interactable) would not receive pointer up events, if the pointer has lost focus on it in the time between pointer down and up.

Additional changes

  • Introduced IRealityToolkitService and IRealityToolkitServiceModule. These interfaces are reserved for future use and used to identify toolkit services and modules within a SF service providers profile
  • Bump SF dependency
  • Merge BaseInteractor and BaseControllerInteractor, there is no need for two base implementations here as of now
  • Introduce IsInputDown as a IInteractor property. The property signals whether there is ANY input being down (held) on the IInteractor
  • Rename DefaultPointerLine material to FarInteractorLine
  • Rename IPointerResult to IInteractorResult
  • Rename PointerData to InteractorResult
  • Updated asset type icons
  • Fix GrabBehaviour grab point math

Breaking Changes

  • Requires an update of the locomotion package for compatibility (separate PR incoming)

@FejZa FejZa enabled auto-merge (squash) November 10, 2023 07:44
@FejZa FejZa merged commit 915cc26 into development Nov 10, 2023
5 checks passed
@FejZa FejZa deleted the bugfix/interactions branch November 10, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants