Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simplifying-gameobect-extensions #64

Merged

Conversation

SimonDarksideJ
Copy link
Contributor

Reality Collective - Utilities Pull Request

Overview

Quality of life updates to the GameObject extensions from further testing

Changes

  • Renamed TryGetComponentInParentHierarchy to TryFindAncestorComponent
  • PROPERLY implemented ComponentInParentHierarchy (an issue even in MRTK)
  • Removed generic constraints from all "get" extensions as they impose limits that Unity does not.

Breaking Changes

  • TryGetComponentInParentHierarchy renamed to TryFindAncestorComponent

(Much better name)

…nt` and properly implemented `FindAncestorComponent`
@SimonDarksideJ SimonDarksideJ requested a review from FejZa as a code owner May 31, 2024 19:30
@SimonDarksideJ SimonDarksideJ enabled auto-merge May 31, 2024 19:30
@SimonDarksideJ SimonDarksideJ disabled auto-merge May 31, 2024 20:19
@SimonDarksideJ SimonDarksideJ merged commit 450cce1 into development May 31, 2024
22 checks passed
@SimonDarksideJ SimonDarksideJ deleted the feature/simplifying-gameobect-extensions branch May 31, 2024 20:20
SimonDarksideJ added a commit that referenced this pull request Sep 5, 2024
* Migrated missing extension from last bounds update and included new reverse hierarchy component search. (#62)
* Added the ability to "Wrap" log messages managed by the logger to make them easier to identify in LogCat and Android debugging output (#63)
* Renamed `TryGetComponentInParentHierarchy` to `TryFindAncestorComponent` and properly implemented `FindAncestorComponent` (#64)

---------
Co-authored-by: Simon Jackson <[email protected]>
Co-authored-by: Dino Fejzagić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant