attempted fix for settings crash

realcopacetic · Aug 4, 2024 · 8a1b227 · 8a1b227
1 parent db24306
commit 8a1b227
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/16x9/Components.xml b/16x9/Components.xml
@@ -41,12 +41,10 @@
 
 	<include name="Focus_Setter">
 		<param name="id" default="4010" />
-		<param name="time" default="0" />
 		<param name="target_id" />
 		<definition>
 			<control type="button" id="$PARAM[id]">
 				<visible allowhiddenfocus="true">false</visible>
-				<animation effect="slide" end="0,0" time="$PARAM[time]" reversible="false">Focus</animation>
 				<onfocus>$PARAM[target_id]</onfocus>
 				<onright>$PARAM[target_id]</onright>
 				<onleft>$PARAM[target_id]</onleft>

diff --git a/16x9/Home.xml b/16x9/Home.xml
@@ -11,7 +11,7 @@
 		<!-- Focus setter added to enable scrollbar to trigger on window load -->
 		<include content="Focus_Setter">
 			<param name="target_id" value="SetFocus(3000)" />
-			<param name="time" value="360" />
+			<animation effect="slide" end="0,0" time="360" reversible="false">Focus</animation>
 		</include>
 		<include content="Home_Container_Update_Bounce_Test" />
 		<include content="User_Scroll_Delay" />

diff --git a/16x9/Templates_Dialogs.xml b/16x9/Templates_Dialogs.xml
@@ -78,7 +78,7 @@
 					<param name="textcolor" value="$VAR[Breadcrumb_Label_Color]" />
 				</include>
 				<include content="Breadcrumb_Label" condition="!String.IsEmpty(ListItem.Endtime) + [String.IsEqual(ListItem.DBType,movie) | String.IsEqual(ListItem.DBTYpe,episode)]">
-					<param name="visible" value="!Window.IsVisible(volumebar) + !Window.IsVisible(notification) + !Window.IsVisible(extendedprogressdialog)" />
+					<param name="visible" value="!Window.IsVisible(volumebar) + !Window.IsVisible(notification) + !Window.IsVisible(extendedprogressdialog) + !$EXP[Music_Player_IsVisible]" />
 					<param name="bar" value="false" />
 					<param name="align" value="right" />
 					<param name="title_label" value="$LOCALIZE[31100]" />

diff --git a/README.md b/README.md
@@ -20,6 +20,10 @@ or send a letter to Creative Commons, 171 Second Street, Suite 300, San Francisc
 
 ### Changelog
 ---
+**2.5.9**
+- Hide dialogvideinfo.xml label for ends time in top right corner when musicplayer widget is active.
+- Attempted fix for crashes in when browsing settings screens on certain platforms, courtesy of @mikeSILVO
+
 **2.5.8**
 - New attempted fix for infoscreen path tracer bug
 

diff --git a/addon.xml b/addon.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<addon id="skin.copacetic" version="2.5.8" name="Copacetic" provider-name="realcopacetic">
+<addon id="skin.copacetic" version="2.5.9" name="Copacetic" provider-name="realcopacetic">
 	<requires>
 		<import addon="xbmc.gui" version="5.17.0" />
 		<import addon="script.copacetic.helper" version="1.1.0" />