Make nullable parameters explicity nullable for PHP 8.4 #111
Conversation
| @@ -164,7 +164,7 @@ public function __construct($cmd, $cwd = null, array $env = null, array $fds = n | |||
| * @param float $interval Interval to periodically monitor process state (seconds) | |||
| * @throws \RuntimeException If the process is already running or fails to start | |||
| */ | |||
| public function start(LoopInterface $loop = null, $interval = 0.1) | |||
| public function start(?LoopInterface $loop = null, $interval = 0.1) | |||
There was a problem hiding this comment.
Could you update this method the same way this method has been updated in another package? https://github.com/reactphp/socket/pull/318/files#diff-2c0b16424077d1ecafdbbca23aa3f137bc007241b00fe55dd536434c147326ca This way we can ensure it runs on all PHP versions in rage
There was a problem hiding this comment.
@emteknetnz Thanks for looking into this. I've just replied with a status update in #110 and plan to get this in for the next release.
Unfortunately this requires a bit more work to support legacy PHP versions as suggested in #108. The good news is, we've already prepared all the required changes there and only need to backport this as discussed in #110.
Once #113 is merged, we can move forward with this. In the meantime, I don't think there's much that needs to be done here. I'll get back to this once we make progress.
|
Closing this PR as it has been resolved through #114 |
Implicitly nullable parameter types are deprecated in PHP 8.4
https://www.php.net/manual/it/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter