Skip to content

Commit

Permalink
Add a workaround for git describe not supporting tag+count without hash
Browse files Browse the repository at this point in the history
  • Loading branch information
learn-more committed Sep 9, 2024
1 parent 448fd52 commit 18bc5b2
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 7 deletions.
1 change: 0 additions & 1 deletion Docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ RUN wget https://downloads.sourceforge.net/reactos/RosBE-Unix-2.2.1.tar.bz2 \
&& rm -rf RosBE-Unix-2.2.1

RUN git clone https://github.com/reactos/Release_Engineering \

&& mv Release_Engineering/Release_* /usr/local/bin \
&& rm -rf Release_Engineering

Expand Down
7 changes: 5 additions & 2 deletions Release_Configure
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,12 @@ else
git checkout "${branch_name}" || exit 1
fi

# Get the suffix from Git if none was entered.
# Get the version from Git if none was entered.
if [ "${version}" = "" ]; then
version=`git describe --abbrev=0`
# Output something like '0.4.15-4-ge1e96bf467b5ea'
version_with_hash=`git describe --always`
# Extract the part before the last dash to ignore the commit hash
version=${version_with_hash%-*}
fi

# Write the config file
Expand Down
15 changes: 11 additions & 4 deletions Release_ISOs
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,20 @@ if [ "$ROS_ARCH" = "" ]; then
exit 1
fi

if [ "$ROS_ARCH" = "i386" ]; then
ROS_PRETTY_ARCH="x86"
else
ROS_PRETTY_ARCH="$ROS_ARCH"
fi


# Constants
ROOTDIR="$PWD"
OUTPUTDIR="output-MinGW-i386"
BOOTCDISO="ReactOS-${version}-${ROS_ARCH}.iso"
BOOTCDZIP="ReactOS-${version}-${ROS_ARCH}-iso.zip"
LIVECDISO="ReactOS-${version}-${ROS_ARCH}-live.iso"
LIVECDZIP="ReactOS-${version}-${ROS_ARCH}-live.zip"
BOOTCDISO="ReactOS-${version}-${ROS_PRETTY_ARCH}.iso"
BOOTCDZIP="ReactOS-${version}-${ROS_PRETTY_ARCH}-iso.zip"
LIVECDISO="ReactOS-${version}-${ROS_PRETTY_ARCH}-live.iso"
LIVECDZIP="ReactOS-${version}-${ROS_PRETTY_ARCH}-live.zip"

# Start from a clean state
rm -f "${ROOTDIR}/${BOOTCDZIP}"
Expand Down

0 comments on commit 18bc5b2

Please sign in to comment.