Fix tests that looks like Assert.True(true) (#291)

reactivemarbles · Oct 12, 2019 · 928e4e2 · 928e4e2
1 parent 2be505f
commit 928e4e2
Show file tree

Hide file tree

Showing 12 changed files with 19 additions and 19 deletions.
diff --git a/src/DynamicData.Tests/Cache/EnumerableObservableToObservableChangeSetFixture.cs b/src/DynamicData.Tests/Cache/EnumerableObservableToObservableChangeSetFixture.cs
@@ -51,7 +51,7 @@ public void LimitSizeTo()
 
             var expected = people.Skip(100).ToArray().OrderBy(p => p.Name).ToArray();
             var actual = results.Data.Items.OrderBy(p => p.Name).ToArray();
-            actual.ShouldAllBeEquivalentTo(actual, "Only second hundred should be in the cache");
+            actual.ShouldAllBeEquivalentTo(expected, "Only second hundred should be in the cache");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/Cache/FilterControllerFixture.cs b/src/DynamicData.Tests/Cache/FilterControllerFixture.cs
@@ -188,7 +188,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -218,7 +218,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 80 messages");
             _results.Data.Count.Should().Be(80, "Should be 80 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/Cache/FilterFixture.cs b/src/DynamicData.Tests/Cache/FilterFixture.cs
@@ -82,7 +82,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -112,7 +112,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 100 updates");
             _results.Data.Count.Should().Be(80, "Should be 100 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/Cache/FilterParallelFixture.cs b/src/DynamicData.Tests/Cache/FilterParallelFixture.cs
@@ -82,7 +82,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Name).ToArray();
-            _results.Data.Items.OrderBy(p => p.Name).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Name), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Name).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -112,7 +112,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 100 updates");
             _results.Data.Count.Should().Be(80, "Should be 100 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/Cache/TransformFixture.cs b/src/DynamicData.Tests/Cache/TransformFixture.cs
@@ -123,7 +123,7 @@ public void BatchOfUniqueUpdates()
                 stub.Results.Messages[0].Adds.Should().Be(100, "Should return 100 adds");
 
                 var transformed = people.Select(stub.TransformFactory).OrderBy(p => p.Age).ToArray();
-                stub.Results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(stub.Results.Data.Items.OrderBy(p => p.Age), "Incorrect transform result");
+                stub.Results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(transformed, "Incorrect transform result");
             }
         }
 

diff --git a/src/DynamicData.Tests/Cache/TransformFixtureParallel.cs b/src/DynamicData.Tests/Cache/TransformFixtureParallel.cs
@@ -86,7 +86,7 @@ public void BatchOfUniqueUpdates()
 
             var transformed = people.Select(_transformFactory).ToArray();
 
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect transform result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(transformed, "Incorrect transform result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/List/FilterControllerFixtureWithClearAndReplace.cs b/src/DynamicData.Tests/List/FilterControllerFixtureWithClearAndReplace.cs
@@ -147,7 +147,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -177,7 +177,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 80 messages");
             _results.Data.Count.Should().Be(80, "Should be 80 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/List/FilterControllerFixtureWithDiffSet.cs b/src/DynamicData.Tests/List/FilterControllerFixtureWithDiffSet.cs
@@ -133,7 +133,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -163,7 +163,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 80 messages");
             _results.Data.Count.Should().Be(80, "Should be 80 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/List/FilterFixture.cs b/src/DynamicData.Tests/List/FilterFixture.cs
@@ -128,7 +128,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -157,7 +157,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 80 updates");
             _results.Data.Count.Should().Be(80, "Should be 100 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/List/FilterWithObservable.cs b/src/DynamicData.Tests/List/FilterWithObservable.cs
@@ -188,7 +188,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(80, "Should return 80 adds");
 
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]
@@ -218,7 +218,7 @@ public void BatchSuccessiveUpdates()
             _results.Messages.Count.Should().Be(80, "Should be 80 messages");
             _results.Data.Count.Should().Be(80, "Should be 80 in the cache");
             var filtered = people.Where(p => p.Age > 20).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect Filter result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(filtered, "Incorrect Filter result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/List/SelectFixture.cs b/src/DynamicData.Tests/List/SelectFixture.cs
@@ -84,7 +84,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(100, "Should return 100 adds");
 
             var transformed = people.Select(_transformFactory).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect transform result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(transformed, "Incorrect transform result");
         }
 
         [Fact]

diff --git a/src/DynamicData.Tests/List/TransformFixture.cs b/src/DynamicData.Tests/List/TransformFixture.cs
@@ -100,7 +100,7 @@ public void BatchOfUniqueUpdates()
             _results.Messages[0].Adds.Should().Be(100, "Should return 100 adds");
 
             var transformed = people.Select(_transformFactory).OrderBy(p => p.Age).ToArray();
-            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect transform result");
+            _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(transformed, "Incorrect transform result");
         }
 
         [Fact]
-Original file line number
+Diff line change
@@ Expand Up / @@ -86,7 +86,7 @@ public void BatchOfUniqueUpdates() @@
                 var transformed = people.Select(_transformFactory).ToArray();
-                _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(_results.Data.Items.OrderBy(p => p.Age), "Incorrect transform result");
+                _results.Data.Items.OrderBy(p => p.Age).ShouldAllBeEquivalentTo(transformed, "Incorrect transform result");
             }
             [Fact]
@@ Expand Down @@