Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update title of Chinese version #64

Merged
merged 1 commit into from
May 24, 2018

Conversation

WayneWang12
Copy link
Contributor

As mentioned in reactivemanifesto/reactivemanifesto#115, update the title of manifesto to "反应式宣言".

@He-Pin
Copy link

He-Pin commented May 24, 2018

@WayneWang12 So does the svg

<text transform="matrix(1 0 0 1 5.7999 68.965)" class="st1 st2 st3">VALUE</text>
<text transform="matrix(1 0 0 1 5.7999 148.965)" class="st1 st2 st3">手段</text>
<text transform="matrix(1 0 0 1 5.7999 238.965)" class="st1 st2 st3">形式</text>
<text transform="matrix(1 0 0 1 5.7999 68.965)" class="st1 st2 st3">价值</text>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep it for now? We need another updating here.

@He-Pin
Copy link

He-Pin commented May 24, 2018

@WayneWang12 Thanks for your hard work.

@He-Pin
Copy link

He-Pin commented May 24, 2018

@rasummer it's Ready to merge I think.

Copy link
Member

@rasummer rasummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rasummer rasummer merged commit 3980e21 into reactivemanifesto:master May 24, 2018
@He-Pin
Copy link

He-Pin commented May 25, 2018

@rasummer When will the website be updated?

@rasummer
Copy link
Member

@jroper when you get a chance, could you deploy the site. thanks

@jroper
Copy link
Member

jroper commented May 29, 2018

Deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants