-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: schema.Entity -> EntityMixin #3243
Conversation
🦋 Changeset detectedLatest commit: 7413225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ae8b080
to
c3a2e89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3243 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 132 132
Lines 2269 2270 +1
Branches 467 467
=======================================
+ Hits 2245 2246 +1
Misses 13 13
Partials 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 7413225 | Previous: f81737c | Ratio |
---|---|---|---|
normalizeLong |
519 ops/sec (±0.26% ) |
507 ops/sec (±0.30% ) |
0.98 |
infer All |
9424 ops/sec (±0.45% ) |
9577 ops/sec (±0.56% ) |
1.02 |
denormalizeLong |
346 ops/sec (±0.75% ) |
346 ops/sec (±0.74% ) |
1 |
denormalizeLong donotcache |
885 ops/sec (±1.20% ) |
882 ops/sec (±2.15% ) |
1.00 |
denormalizeShort donotcache 500x |
1342 ops/sec (±1.15% ) |
1374 ops/sec (±0.19% ) |
1.02 |
denormalizeShort 500x |
985 ops/sec (±0.38% ) |
972 ops/sec (±0.31% ) |
0.99 |
denormalizeShort 500x withCache |
4820 ops/sec (±0.16% ) |
4795 ops/sec (±0.20% ) |
0.99 |
denormalizeLong with mixin Entity |
302 ops/sec (±0.40% ) |
300 ops/sec (±0.38% ) |
0.99 |
denormalizeLong withCache |
6701 ops/sec (±0.58% ) |
6201 ops/sec (±0.17% ) |
0.93 |
denormalizeLong All withCache |
6527 ops/sec (±0.16% ) |
6394 ops/sec (±0.76% ) |
0.98 |
denormalizeLong Query-sorted withCache |
6480 ops/sec (±0.22% ) |
6292 ops/sec (±0.52% ) |
0.97 |
denormalizeLongAndShort withEntityCacheOnly |
1496 ops/sec (±0.56% ) |
1505 ops/sec (±0.72% ) |
1.01 |
getResponse |
6079 ops/sec (±1.18% ) |
5941 ops/sec (±1.21% ) |
0.98 |
getResponse (null) |
5285931 ops/sec (±0.42% ) |
5273056 ops/sec (±0.80% ) |
1.00 |
getResponse (clear cache) |
291 ops/sec (±0.46% ) |
297 ops/sec (±0.44% ) |
1.02 |
getSmallResponse |
2643 ops/sec (±0.20% ) |
2692 ops/sec (±0.28% ) |
1.02 |
getSmallInferredResponse |
2040 ops/sec (±0.59% ) |
2071 ops/sec (±0.27% ) |
1.02 |
getResponse Query-sorted |
6809 ops/sec (±0.37% ) |
6638 ops/sec (±0.76% ) |
0.97 |
getResponse Collection |
5913 ops/sec (±0.64% ) |
6231 ops/sec (±1.56% ) |
1.05 |
get Collection |
4950 ops/sec (±1.21% ) |
5406 ops/sec (±1.13% ) |
1.09 |
setLong |
515 ops/sec (±0.59% ) |
504 ops/sec (±0.41% ) |
0.98 |
setLongWithMerge |
204 ops/sec (±0.32% ) |
203 ops/sec (±0.31% ) |
1.00 |
setLongWithSimpleMerge |
216 ops/sec (±0.34% ) |
212 ops/sec (±0.43% ) |
0.98 |
setSmallResponse 500x |
901 ops/sec (±0.30% ) |
910 ops/sec (±0.20% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
7b2d8b8
to
2367f3d
Compare
b9e8de4
to
009e759
Compare
Motivation
Clearer naming
Solution
schema.Entity
-> EntityMixinWe keep
schema.Entity
for legacy, and add schema.EntityMixin and EntityMixin as direct export