Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move /hooks package into /react pkg #3115

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat: Move /hooks package into /react pkg #3115

merged 1 commit into from
Jun 20, 2024

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jun 20, 2024

Motivation

Less installs and brain power to think of what package the hooks are in.

Solution

Mark @data-client/hooks as deprecated. All hooks moved to @data-client/react

Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 0e6b6b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@data-client/react Patch
@data-client/hooks Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.76%. Comparing base (abd9e14) to head (0e6b6b5).

Files Patch % Lines
packages/react/src/hooks/useCancelling.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
- Coverage   98.78%   98.76%   -0.03%     
==========================================
  Files         125      128       +3     
  Lines        2230     2271      +41     
  Branches      452      458       +6     
==========================================
+ Hits         2203     2243      +40     
  Misses         16       16              
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker force-pushed the hooks branch 3 times, most recently from 784bea8 to 42940a7 Compare June 20, 2024 12:56
@ntucker ntucker merged commit 34f12c4 into master Jun 20, 2024
25 checks passed
@ntucker ntucker deleted the hooks branch June 20, 2024 13:26
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant