Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Endpoint.sideEffect can be #3006

Merged
merged 1 commit into from
Apr 13, 2024
Merged

enhance: Endpoint.sideEffect can be #3006

merged 1 commit into from
Apr 13, 2024

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Apr 13, 2024

Motivation

More intuitive; supports sideEffect overrides when using loosenulltypes

Solution

Support was already added to consumers (@data-client/react), so these will be supported by existing versions (0.11)

Copy link

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: 660398d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@data-client/endpoint Minor
@data-client/graphql Minor
@data-client/rest Minor
@data-client/img Minor
example-benchmark Patch
normalizr-github-example Patch
normalizr-redux-example Patch
normalizr-relationships Patch
rdc-website Patch
coinbase-lite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (18ec81e) to head (660398d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3006   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         119      119           
  Lines        2154     2154           
  Branches      435      435           
=======================================
  Hits         2121     2121           
  Misses         21       21           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker merged commit 13c6466 into master Apr 13, 2024
24 checks passed
@ntucker ntucker deleted the sideeffect-false branch April 13, 2024 10:03
@github-actions github-actions bot mentioned this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant