Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: state.results -> state.endpoints #2971

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Mar 7, 2024

Motivation

Improve clarity by consistent naming

Solution

The store's state.results contains the endpoint-level caching keyed by endpoint key. Thus, it makes more sense to change this to 'endpoints' so its naming is consistent with the 'state.entities' part. We also updating globalCache references in normalizr package.

state.results -> state.endpoints.

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: f5af7a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@data-client/normalizr Minor
@data-client/react Minor
@data-client/core Minor
@data-client/hooks Patch
example-benchmark Patch
normalizr-github-example Patch
normalizr-relationships Patch
@data-client/redux Minor
coinbase-lite Patch
rdc-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (51427ac) to head (f5af7a1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2971   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         117      117           
  Lines        2085     2085           
  Branches      417      417           
=======================================
  Hits         2058     2058           
  Misses         16       16           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker force-pushed the state.endpoints branch 2 times, most recently from b1e1719 to f5af7a1 Compare March 7, 2024 14:10
@ntucker ntucker merged commit b738e18 into master Mar 7, 2024
25 checks passed
@ntucker ntucker deleted the state.endpoints branch March 7, 2024 14:26
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant