-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow practical combination of Query with any schema #2837
Conversation
🦋 Changeset detectedLatest commit: de19d0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2064027
to
adbdb71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
- Coverage 98.58% 98.58% -0.01%
==========================================
Files 116 116
Lines 1907 1906 -1
Branches 277 276 -1
==========================================
- Hits 1880 1879 -1
Misses 14 14
Partials 13 13
☔ View full report in Codecov by Sentry. |
Motivation
Use collections and queries together to make use of their filtering capabilities
Solution
Query uses args provided in normalize
args
were previously not provided during denormalize, so they were hacked into query by placing them from infer into the input.Open questions
Without the hack, it's questionable whether QueryEndpoint is still needed.
process()
could be incorporated into various schemas, and then one schema->endpoint could be used for both index and 'query' use case.