enhance: Remove dispatch from StoreContext

reactive · Jun 19, 2024 · 96b683b · 96b683b
1 parent afe0640
commit 96b683b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/.changeset/funny-socks-cheat.md b/.changeset/funny-socks-cheat.md
@@ -0,0 +1,7 @@
+---
+'@data-client/react': patch
+---
+
+Remove need for dispatch in StoreContext as it is never used
+
+This should have no affect unless you're working with internals of Data Client
diff --git a/packages/react/src/context.ts b/packages/react/src/context.ts
@@ -31,14 +31,12 @@ export const ControllerContext = createContext<Controller>(
 
 export interface Store<S> {
   subscribe(listener: () => void): () => void;
-  dispatch: React.Dispatch<ActionTypes>;
   getState(): S;
   uninitialized?: boolean;
 }
 /* istanbul ignore next */
 export const StoreContext = createContext<Store<State<unknown>>>({
   subscribe: listener => () => {},
-  dispatch: () => {},
   getState: () => initialState,
   uninitialized: true,
 });
diff --git a/packages/react/src/server/SSRDataProvider.tsx b/packages/react/src/server/SSRDataProvider.tsx
@@ -33,11 +33,8 @@ export default function SSRDataProvider({
   devButton,
   hasDevManager = true,
 }: Props<State<any>>) {
-  const controller = useMemo(() => new Controller({ dispatch }), []);
-  const store = useMemo(
-    () => ({ subscribe, dispatch, getState }),
-    [subscribe, dispatch, getState],
-  );
+  const controller = useMemo(() => new Controller({ dispatch }), [dispatch]);
+  const store = useMemo(() => ({ subscribe, getState }), [subscribe, getState]);
 
   return (
     <StoreContext.Provider value={store}>

diff --git a/packages/react/src/server/redux/ExternalDataProvider.tsx b/packages/react/src/server/redux/ExternalDataProvider.tsx
@@ -20,13 +20,11 @@ import {
   StoreContext,
   BackupLoading,
   UniversalSuspense,
-  usePromisifiedDispatch,
   StateContext,
 } from '../../index.js';
 
 interface Store<S> {
   subscribe(listener: () => void): () => void;
-  dispatch: React.Dispatch<ActionTypes>;
   getState(): S;
 }
 interface Props<S> {
@@ -73,8 +71,6 @@ export default function ExternalDataProvider<S>({
     return unsubscribe;
   }, [selectState, store]);
 
-  const dispatch = usePromisifiedDispatch(store.dispatch, state);
-
   const adaptedStore = useMemo(() => {
     return { ...store, getState: () => selector(store.getState()) };
   }, [selector, store]);