Skip to content

Commit

Permalink
internal: Do not globally install corepack
Browse files Browse the repository at this point in the history
  • Loading branch information
ntucker committed Feb 20, 2024
1 parent 6d4549a commit 825ca51
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
- run:
name: yarn install
command: |
sudo npm install -g corepack
sudo corepack enable
YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn workspace todo-app add @data-client/endpoint@workspace:^ @data-client/react@workspace:^ @data-client/rest@workspace:^
YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn workspace github-app add @data-client/graphql@workspace:^ @data-client/hooks@workspace:^ @data-client/react@workspace:^ @data-client/rest@workspace:^
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
cache: 'yarn'
- name: Install packages
run: |
npm install -g corepack
corepack enable
yarn install --immutable
- name: Build packages
Expand Down

1 comment on commit 825ca51

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 825ca51 Previous: 5771da3 Ratio
normalizeLong 457 ops/sec (±1.74%) 447 ops/sec (±1.68%) 0.98
infer All 9933 ops/sec (±0.45%) 9629 ops/sec (±1.67%) 0.97
denormalizeLong 316 ops/sec (±2.40%) 321 ops/sec (±2.22%) 1.02
denormalizeLong donotcache 860 ops/sec (±0.14%) 888 ops/sec (±0.46%) 1.03
denormalizeShort donotcache 500x 1374 ops/sec (±0.29%) 1351 ops/sec (±0.13%) 0.98
denormalizeShort 500x 961 ops/sec (±0.14%) 958 ops/sec (±0.24%) 1.00
denormalizeLong with mixin Entity 304 ops/sec (±0.34%) 303 ops/sec (±0.26%) 1.00
denormalizeLong withCache 7008 ops/sec (±0.12%) 6836 ops/sec (±0.26%) 0.98
denormalizeLongAndShort withEntityCacheOnly 1582 ops/sec (±0.43%) 1562 ops/sec (±0.31%) 0.99
denormalizeLong All withCache 6294 ops/sec (±0.10%) 6337 ops/sec (±0.17%) 1.01
denormalizeLong Query-sorted withCache 6305 ops/sec (±0.25%) 6647 ops/sec (±0.38%) 1.05
getResponse 4854 ops/sec (±0.98%) 4951 ops/sec (±0.88%) 1.02
getResponse (null) 2828568 ops/sec (±0.42%) 2888601 ops/sec (±0.21%) 1.02
getResponse (clear cache) 292 ops/sec (±0.93%) 292 ops/sec (±1.10%) 1
getSmallResponse 2264 ops/sec (±0.37%) 2328 ops/sec (±0.30%) 1.03
getSmallInferredResponse 1794 ops/sec (±0.25%) 1765 ops/sec (±0.34%) 0.98
getResponse Query-sorted 742 ops/sec (±1.30%) 687 ops/sec (±1.09%) 0.93
getResponse Collection 4817 ops/sec (±0.81%) 5124 ops/sec (±1.06%) 1.06
setLong 434 ops/sec (±2.70%) 437 ops/sec (±2.25%) 1.01
setLongWithMerge 188 ops/sec (±0.36%) 189 ops/sec (±0.36%) 1.01
setLongWithSimpleMerge 202 ops/sec (±0.24%) 202 ops/sec (±0.27%) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.